Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to avoid cache confusion #400

Merged
merged 3 commits into from
Sep 24, 2021
Merged

try to avoid cache confusion #400

merged 3 commits into from
Sep 24, 2021

Conversation

bodewig
Copy link
Collaborator

@bodewig bodewig commented Sep 23, 2021

closes #399

If you've got two differently configured locations the cache may allow tokens accepted by one location to be used at a different one - even if they would not be valid for the other location's configuration.

This PR does three things:

  • separate the caches for JWT verification and token introspection
  • use some of the configuration settings of opts as part of the cache key. I later realized this is probably futile so I added explicit configuration via the third step
  • adds an option to segregate the cache by assigning a "segment" to a set of related locations

@zandbelt I'm not sure whether we want to leave in the second part at all or just stick with the user-controlled configuration.

@bodewig bodewig requested a review from zandbelt September 23, 2021 19:07
see #399

Signed-off-by: Stefan Bodewig <stefan.bodewig@innoq.com>
see #399

Signed-off-by: Stefan Bodewig <stefan.bodewig@innoq.com>
see #399

Signed-off-by: Stefan Bodewig <stefan.bodewig@innoq.com>
@bodewig bodewig force-pushed the harden-introspection-cache branch from bf162bb to 1e1e66f Compare September 23, 2021 19:17
@bodewig bodewig merged commit 5c8cb34 into master Sep 24, 2021
@bodewig bodewig deleted the harden-introspection-cache branch October 28, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Vulnerability - Server Cache allows bypass of JWT Validation
2 participants