Use execnet main_thread_only execmodel

.github/workflows/deploy.yml

@@ -19,7 +19,7 @@ jobs:
     - uses: actions/checkout@v4
 
     - name: Build and Check Package
-      uses: hynek/build-and-inspect-python-package@v2.0
+      uses: hynek/build-and-inspect-python-package@v2.2
 
   deploy:
     needs: package
@@ -39,7 +39,7 @@ jobs:
         path: dist
 
     - name: Publish package to PyPI
-      uses: pypa/gh-action-pypi-publish@v1.8.11
+      uses: pypa/gh-action-pypi-publish@v1.8.14
 
     - name: Push tag
       run: |
@@ -49,7 +49,7 @@ jobs:
         git push origin v${{ github.event.inputs.version }}
 
     - name: GitHub Release
-      uses: softprops/action-gh-release@v1
+      uses: softprops/action-gh-release@v2
       with:
         files: dist/*
         tag_name: v${{ github.event.inputs.version }}

.github/workflows/test.yml

@@ -22,7 +22,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Build and Check Package
-      uses: hynek/build-and-inspect-python-package@v2.0
+      uses: hynek/build-and-inspect-python-package@v2.2
 
   test:
 
@@ -34,7 +34,7 @@ jobs:
       fail-fast: false
       matrix:
         tox_env:
-          - "py37-pytestlatest"
+          - "py38-pytestmin"
           - "py38-pytestlatest"
           - "py39-pytestlatest"
           - "py310-pytestlatest"
@@ -46,8 +46,8 @@ jobs:
 
         os: [ubuntu-latest, windows-latest]
         include:
-          - tox_env: "py37-pytestlatest"
-            python: "3.7"
+          - tox_env: "py38-pytestmin"
+            python: "3.8"
           - tox_env: "py38-pytestlatest"
             python: "3.8"
           - tox_env: "py39-pytestlatest"

.pre-commit-config.yaml

@@ -1,35 +1,19 @@
 repos:
--   repo: https://github.com/PyCQA/autoflake
-    rev: v2.3.0
-    hooks:
-    -   id: autoflake
-        args: ["--in-place", "--remove-unused-variables", "--remove-all-unused-imports"]
--   repo: https://github.com/psf/black
-    rev: 24.2.0
-    hooks:
-    -   id: black
-        args: [--safe, --quiet, --target-version, py35]
+- repo: https://github.com/astral-sh/ruff-pre-commit
+  rev: "v0.3.7"
+  hooks:
+    - id: ruff
+      args: ["--fix"]
+    - id: ruff-format
 -   repo: https://github.com/asottile/blacken-docs
     rev: 1.16.0
     hooks:
     -   id: blacken-docs
         additional_dependencies: [black==23.1.0]
 -   repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.5.0
+    rev: v4.6.0
     hooks:
-    -   id: trailing-whitespace
-    -   id: end-of-file-fixer
     -   id: check-yaml
-    -   id: debug-statements
--   repo: https://github.com/PyCQA/flake8
-    rev: 7.0.0
-    hooks:
-    -   id: flake8
--   repo: https://github.com/asottile/pyupgrade
-    rev: v3.15.1
-    hooks:
-    -   id: pyupgrade
-        args: [--py3-plus]
 -   repo: local
     hooks:
     -   id: rst
@@ -39,11 +23,13 @@ repos:
         language: python
         additional_dependencies: [pygments, restructuredtext_lint]
 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.8.0
+    rev: v1.9.0
     hooks:
     -   id: mypy
         files: ^(src/|testing/)
         args: []
         additional_dependencies:
-          - pytest>=6.2.0
-          - py>=1.10.0
+          - pytest>=7.0.0
+          - execnet>=2.1.0
+          - types-psutil
+          - setproctitle

changelog/1024.bugfix

@@ -0,0 +1,2 @@
+Added proper handling of ``shouldstop`` (such as set by ``--max-fail``) and ``shouldfail`` conditions in workers.
+Previously, a worker might have continued executing further tests before the controller could terminate the session.

changelog/1027.improvement.rst

@@ -0,0 +1,3 @@
+``pytest-xdist`` workers now always execute the tests in the main thread.
+
+Previously some tests might end up executing in a separate thread other than ``main`` in the workers, due to some internal `èxecnet`` details. This can cause problems specially with async frameworks where the event loop is running in the ``main`` thread (for example `#620 <https://github.com/pytest-dev/pytest-xdist/issues/620>`__).

changelog/1028.bugfix

@@ -0,0 +1 @@
+Fix compatiblity issue between `looponfail` and editable installs.

changelog/1053.removal

@@ -0,0 +1 @@
+Dropped support for Python 3.7.

changelog/1057.removal

@@ -0,0 +1,3 @@
+pytest>=7.0.0 is now required.
+
+execnet>=2.1.0 is now required.

changelog/1057.trivial

@@ -0,0 +1 @@
+The internals of pytest-xdist are now fully typed. The typing is not exposed yet.

changelog/620.bugfix

@@ -0,0 +1 @@
+Use the ``execnet`` new ``main_thread_only`` "execmodel" so that code which expects to only run in the main thread will now work as expected.

changelog/937.bugfix

@@ -0,0 +1 @@
+Fix a bug where plugin would raise an incompatibility error with ``--pdb`` despite using ``-n0``.

pyproject.toml

@@ -25,17 +25,16 @@ classifiers = [
     "Programming Language :: Python",
     "Programming Language :: Python :: 3",
     "Programming Language :: Python :: 3 :: Only",
-    "Programming Language :: Python :: 3.7",
     "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
 ]
-requires-python = ">=3.7"
+requires-python = ">=3.8"
 dependencies = [
-    "execnet>=1.1",
-    "pytest>=6.2.0",
+    "execnet>=2.1",
+    "pytest>=7.0.0",
 ]
 dynamic = ["version"]
 
@@ -67,26 +66,82 @@ include-package-data = false
 [tool.setuptools_scm]
 write_to = "src/xdist/_version.py"
 
-[tool.flake8]
-# Ignore any errors related to formatting, let black worry/fix them.
-ignore = ["E501", "W503", "E203"]
-max-line-length = 100
+[tool.ruff]
+src = ["src"]
+
+[tool.ruff.format]
+docstring-code-format = true
+
+[tool.ruff.lint]
+select = [
+    "B",        # bugbear
+    "D",        # pydocstyle
+    "E",        # pycodestyle
+    "F",        # pyflakes
+    "I",        # isort
+    "PYI",      # flake8-pyi
+    "UP",       # pyupgrade
+    "RUF",      # ruff
+    "W",        # pycodestyle
+    "T10",      # flake8-debugger
+    "PIE",      # flake8-pie
+    "FA",       # flake8-future-annotations
+    "PGH",      # pygrep-hooks
+    "PLE",      # pylint error
+    "PLW",      # pylint warning
+    "PLR1714",  # Consider merging multiple comparisons
+]
+ignore = [
+    # bugbear ignore
+    "B011",     # Do not `assert False` (`python -O` removes these calls)
+    "B028",     # No explicit `stacklevel` keyword argument found
+    # pydocstyle ignore
+    "D100",     # Missing docstring in public module
+    "D101",     # Missing docstring in public class
+    "D102",     # Missing docstring in public method
+    "D103",     # Missing docstring in public function
+    "D104",     # Missing docstring in public package
+    "D105",     # Missing docstring in magic method
+    "D106",     # Missing docstring in public nested class
+    "D107",     # Missing docstring in `__init__`
+    "D209",     # Multi-line docstring closing quotes should be on a separate line
+    "D205",     # 1 blank line required between summary line and description
+    "D400",     # First line should end with a period
+    "D401",     # First line of docstring should be in imperative mood
+    # ruff ignore
+    "RUF012",   # Mutable class attributes should be annotated with `typing.ClassVar`
+    # pylint ignore
+    "PLW0603",  # Using the global statement
+    "PLW0120",  # remove the else and dedent its contents
+    "PLW2901",  # for loop variable overwritten by assignment target
+    "PLR5501",  # Use `elif` instead of `else` then `if`
+]
+
+[tool.ruff.lint.pycodestyle]
+# In order to be able to format for 88 char in ruff format
+max-line-length = 120
+
+[tool.ruff.lint.pydocstyle]
+convention = "pep257"
+
+[tool.ruff.lint.isort]
+force-single-line = true
+combine-as-imports = true
+force-sort-within-sections = true
+order-by-type = false
+lines-after-imports = 2
+
+[tool.ruff.lint.per-file-ignores]
+"src/xdist/_version.py" = ["I001"]
 
 [tool.mypy]
 mypy_path = ["src"]
-# TODO: Enable this & fix errors.
-# check_untyped_defs = true
-disallow_any_generics = true
-ignore_missing_imports = true
-no_implicit_optional = true
-show_error_codes = true
-strict_equality = true
-warn_redundant_casts = true
-warn_return_any = true
+files = ["src", "testing"]
+strict = true
 warn_unreachable = true
-warn_unused_configs = true
-# TODO: Enable this & fix errors.
-# no_implicit_reexport = true
+[[tool.mypy.overrides]]
+module = ["xdist._version"]
+ignore_missing_imports = true
 
 
 [tool.towncrier]

src/xdist/__init__.py

@@ -1,10 +1,9 @@
-from xdist.plugin import (
-    is_xdist_worker,
-    is_xdist_master,
-    get_xdist_worker_id,
-    is_xdist_controller,
-)
 from xdist._version import version as __version__
+from xdist.plugin import get_xdist_worker_id
+from xdist.plugin import is_xdist_controller
+from xdist.plugin import is_xdist_master
+from xdist.plugin import is_xdist_worker
+
 
 __all__ = [
     "__version__",

src/xdist/_path.py

@@ -1,7 +1,8 @@
-import os
 from itertools import chain
+import os
 from pathlib import Path
-from typing import Callable, Iterator
+from typing import Callable
+from typing import Iterator
 
 
 def visit_path(