-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shields): Add Fifi Shield Support #1008
Conversation
Co-authored-by: Nick Winans <nick@winans.codes>
Co-authored-by: Nick Winans <nick@winans.codes>
Co-authored-by: Nick Winans <nick@winans.codes>
Co-authored-by: Nick Winans <nick@winans.codes>
Co-authored-by: Nick Winans <nick@winans.codes>
Co-authored-by: Nick Winans <nick@winans.codes>
@Nicell added the missing copyright lines, updated to 2022, ditched the changes to build.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the fifi_left.conf
and fifi_right.conf
files! Otherwise I think this definition looks good. Thanks. You can re-request my review after updating.
Hi @petejohanson, rebased with main and then reapplied my changes, but I'm getting the below:
https://github.com/hmngwy/zmk/actions/runs/4234720633/jobs/7357427250#step:10:140 I'm not quite sure what I'm doing wrong, I checked the New Keyboard Shields guide as well if anything there is new since I slept on this PR, and it seems what I added here seems to still comply, however the error says otherwise and I can't tell what I'm missing. If you're not too busy, a quick look would be appreciated. Thanks! |
@hmngwy You should be building with |
Board/Shield Check-list
.zmk.yml
metadata file added&pro_micro
used in favor of&pro_micro_d/a
if applicable.conf
file has optional extra features commented out