-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shields): Add Breeze #1125
base: main
Are you sure you want to change the base?
Conversation
// ---------------------------------------------------------------------------------------------------------------------------------- | ||
// | | | | | | | | | | | | | | | | | | | ||
// | ` | 1 | 2 | 3 | 4 | 5 | | 6 | 7 | 8 | 9 | 0 | | | | | | | ||
// | F1 | F2 | F3 | F4 | F5 | F6 | | | <- | ^ | v | -> | | | | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan based on the keymap (line 61), shouldn't the order of the arrows be like this?
| <- | v | ^ | -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch @peterlvno! The keymap is correct, it's the illustrative comments that are wrong. I'll correct later today, I have also made some other tweaks to this layout that make sense as a default. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterlvno okay, I cleaned up the default keymap to something way simpler in 0973971, and I think there are no lingering mistakes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor things.
Add a shield definition for the Breeze split keyboard from Afternoon labs. This is for the standard breeze variant, with the arrow keys present on the right half but not the left. Definition is based in part on an abandoned PR by @devries: zmkfirmware#735 Signed-off-by: Idan Gazit <idan@gazit.me> Co-authored-by: devriesp <devriesp@users.noreply.github.com> Signed-off-by: Idan Gazit <idan@gazit.me>
Signed-off-by: Idan Gazit <idan@gazit.me>
Signed-off-by: Idan Gazit <idan@gazit.me>
Signed-off-by: Idan Gazit <idan@gazit.me>
- add arrows keys on lower WASD - Add LA PSCRN to media block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on the new transform added, and then if you could delete breeze_left.conf and breeze_right.conf, that'd be perfect. We're keeping only the main shield.conf file in tree.
@Nicell @petejohanson bump; I think this should be ready now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan Sorry, I found one more thing on this review, then I think we're good to go.
&kscan0 { | ||
row-gpios | ||
= <&pro_micro 21 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
, <&pro_micro 20 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
, <&pro_micro 19 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
, <&pro_micro 18 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
, <&pro_micro 15 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)> | ||
; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see these are the same GPIO as the ones in the left .overlay. This can probably just be put in the .dtsi then instead of in each, right? The left side can just have the include line and on the right side the include and row offset.
Howdy! I am looking to adapt my Afternoon Breeze to use ZMK - any chance I could bump this issue and hope y'all could push it over the finish line? I'm wayyy to new to this project to even have a hope of closing it out myself haha |
@houllette If you want to unblock yourself, you can copy the |
While the pull requests are still open, the main ZMK repository is de facto not accepting shield additions or changes. Consider forking Afternoon Labs' config repository. While it doesn't have all the improvements of #1312, being under the Afternoon Labs account gives it additional visibility. So it likely has the highest chance of being maintained. |
@caksoylar @lesshonor - thank you both so much! This should be enough to go off of; I appreciate it! |
Add a shield definition for the Breeze split keyboard from Afternoon
labs.
This is for the standard breeze variant, with the arrow keys present
on the right half but not the left.
Definition is based in part on an abandoned PR by @devries:
#735
Signed-off-by: Idan Gazit idan@gazit.me
Co-authored-by: devriesp devriesp@users.noreply.github.com
Board/Shield Check-list
.zmk.yml
metadata file added&pro_micro
used in favor of&pro_micro_d/a
if applicable.conf
file has optional extra features commented out