-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): Added a page on shift registers #2452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
caksoylar
reviewed
Sep 2, 2024
Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
caksoylar
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall besides noted nits. If no one has technical concerns on recommendations such as the max frequency value, you can merge when you like.
Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
Liam-Weitzel
pushed a commit
to Liam-Weitzel/zmk
that referenced
this pull request
Sep 10, 2024
Added a page on shift registers --------- Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
rafaelromao
pushed a commit
to rafaelromao/zmk
that referenced
this pull request
Oct 8, 2024
Added a page on shift registers --------- Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
lammai
pushed a commit
to lammai/zmk
that referenced
this pull request
Oct 27, 2024
Added a page on shift registers --------- Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
EnotionZ
pushed a commit
to EnotionZ/zmk
that referenced
this pull request
Nov 6, 2024
Added a page on shift registers --------- Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a page documenting some stuff on shift registers. Not quite sure whether any more detail than this should be written - anything more specific applies to not that many people I think, and the configuration becomes more complex.