Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Added a page on shift registers #2452

Merged
merged 22 commits into from
Sep 7, 2024

Conversation

Nick-Munnich
Copy link
Contributor

@Nick-Munnich Nick-Munnich commented Sep 1, 2024

Added a page documenting some stuff on shift registers. Not quite sure whether any more detail than this should be written - anything more specific applies to not that many people I think, and the configuration becomes more complex.

@Nick-Munnich Nick-Munnich marked this pull request as ready for review September 2, 2024 10:45
@Nick-Munnich Nick-Munnich requested a review from a team as a code owner September 2, 2024 10:45
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall besides noted nits. If no one has technical concerns on recommendations such as the max frequency value, you can merge when you like.

Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
@Nick-Munnich Nick-Munnich added the documentation Improvements or additions to documentation label Sep 3, 2024
@Nick-Munnich Nick-Munnich merged commit f0319fd into zmkfirmware:main Sep 7, 2024
7 checks passed
@Nick-Munnich Nick-Munnich deleted the shift-registers branch September 7, 2024 11:19
Liam-Weitzel pushed a commit to Liam-Weitzel/zmk that referenced this pull request Sep 10, 2024
Added a page on shift registers
---------

Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
rafaelromao pushed a commit to rafaelromao/zmk that referenced this pull request Oct 8, 2024
Added a page on shift registers
---------

Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
lammai pushed a commit to lammai/zmk that referenced this pull request Oct 27, 2024
Added a page on shift registers
---------

Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
EnotionZ pushed a commit to EnotionZ/zmk that referenced this pull request Nov 6, 2024
Added a page on shift registers
---------

Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants