-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Pro Micro pin mapping #876
Refactor Pro Micro pin mapping #876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick. Appreciate the backwards compatible approach, and getting all existing shields updated to help set proper examples moving forward.
b88b294
to
723fd0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on how to prevent new shields getting merged in w/ the old names? Add an item to the check-list to make sure we're keeping an eye out for it?
It doesn't look like there's a way to add a deprecation warning to our nexus nodes in DT, so no way to really detect usage. A check-list item seems like the best idea for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is much better.
This PR refactors the Pro Micro pin mapping:
pro_micro_d
topro_micro
(pro_micro_d
alias included for compatibility)pro_micro_a
in favor ofpro_micro