Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Pro Micro pin mapping #876

Merged
merged 3 commits into from
Sep 26, 2021

Conversation

Nicell
Copy link
Member

@Nicell Nicell commented Jul 24, 2021

This PR refactors the Pro Micro pin mapping:

  • Adds in the missing pins 18-21
  • Renames pro_micro_d to pro_micro (pro_micro_d alias included for compatibility)
  • Removes all uses of pro_micro_a in favor of pro_micro
  • Updates documentation image + description of Pro Micro pins

@Nicell Nicell added enhancement New feature or request board PRs and issues related to boards. shields PRs and issues related to shields labels Jul 24, 2021
@Nicell Nicell requested a review from petejohanson July 24, 2021 19:21
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick. Appreciate the backwards compatible approach, and getting all existing shields updated to help set proper examples moving forward.

docs/docs/development/boards-shields-keymaps.md Outdated Show resolved Hide resolved
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on how to prevent new shields getting merged in w/ the old names? Add an item to the check-list to make sure we're keeping an eye out for it?

@Nicell
Copy link
Member Author

Nicell commented Sep 26, 2021

Thoughts on how to prevent new shields getting merged in w/ the old names? Add an item to the check-list to make sure we're keeping an eye out for it?

It doesn't look like there's a way to add a deprecation warning to our nexus nodes in DT, so no way to really detect usage. A check-list item seems like the best idea for now.

Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board PRs and issues related to boards. enhancement New feature or request refactor shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants