Fixed remove of mention and unnecessary errors in the log. (#295)

Co-authored-by: Denny Korsukéwitz <dennykorsukewitz@gmail.com> Co-authored-by: Niklas <ns@znuny.com>
znuny · Jul 27, 2023 · 4e4b5a0 · 4e4b5a0
1 parent 31b426c
commit 4e4b5a0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Kernel/System/Mention.pm b/Kernel/System/Mention.pm
@@ -645,7 +645,7 @@ sub GetMentionedUserIDsFromString {
         push @UniqueMentionedUsers, $MentionedUser;
     }
 
-    if ( $Param{Limit} ) {
+    if ( $Param{Limit} && @UniqueMentionedUsers > $Param{Limit} ) {
         @UniqueMentionedUsers = @UniqueMentionedUsers[ 0 .. $Param{Limit} - 1 ];
     }
 

diff --git a/var/httpd/htdocs/js/Znuny.Agent.MentionAction.js b/var/httpd/htdocs/js/Znuny.Agent.MentionAction.js
@@ -23,7 +23,8 @@ Znuny.Agent.MentionAction = (function (TargetNS) {
         };
 
         $('.MentionRow').each(function() {
-            $(this).on('click', function() {
+            $(this).on('click', function(Event) {
+                Event.preventDefault();
                 Data.MentionedUserID = $(this).attr('data-user-id');
 
                 Core.AJAX.FunctionCall(

diff --git a/var/httpd/htdocs/js/Znuny.Agent.TicketMention.js b/var/httpd/htdocs/js/Znuny.Agent.TicketMention.js
@@ -22,7 +22,9 @@ Znuny.Agent.TicketMention = (function (TargetNS) {
             BulkAction: 1
         };
 
-        $('#RemoveMention').on('click',function(){
+        $('#RemoveMention').on('click',function(Event){
+            Event.preventDefault();
+
             $('.MasterAction').each(function(){
                 var TicketID  = $(this).attr('id').replace('TicketID_', '');
                 Data.TicketID = TicketID;