Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed double encoding for dynamic field values in the linked-tickets-table #300

Merged
merged 10 commits into from
Jul 21, 2023
Merged

Fixed double encoding for dynamic field values in the linked-tickets-table #300

merged 10 commits into from
Jul 21, 2023

Conversation

tipue-dev
Copy link
Contributor

Proposed change

The values of dynamic fields in the complex link table in the AgentTicketZoom are overly encoded. <b>Big</b> Is the value
image

This change would fix it to

image

Type of change

1 - 🐞 bug 🐞

Breaking change

Additional information

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy run passes successfully.(❕)
  • Local unit tests pass.(❕)
  • GitHub workflow ZnunyCodePolicy passes.(❗)
  • GitHub workflow unit tests pass.(❗)

@dennykorsukewitz dennykorsukewitz added 1 - 🐞 bug 🐞 An issue with the system. 4 - clarification The issue or pull requests needs more information. 3 - wait for reviewer Znuny, it's your turn. 2 - Frontend labels Oct 26, 2022
@dennykorsukewitz dennykorsukewitz added this to the rel-7_0_6 milestone Jun 9, 2023
@dennykorsukewitz dennykorsukewitz modified the milestones: rel-7_0_6, rel-6_5_3 Jun 9, 2023
@NiklasSchmitt NiklasSchmitt added 4 - verified This issue or pull request was verified. and removed 4 - clarification The issue or pull requests needs more information. 3 - wait for reviewer Znuny, it's your turn. labels Jul 21, 2023
@NiklasSchmitt NiklasSchmitt modified the milestones: rel-6_5_4, rel-7_0_9 Jul 21, 2023
@NiklasSchmitt NiklasSchmitt merged commit 02da093 into znuny:dev Jul 21, 2023
13 of 14 checks passed
@NiklasSchmitt
Copy link
Contributor

Approved. Will be part of the next Znuny versions 7.0.9 and also 6.5.4

dennykorsukewitz added a commit to dennykorsukewitz/Znuny that referenced this pull request Jul 9, 2024
@tipue-dev @dennykorsukewitz @NiklasSchmitt
Fixed double encoding for dynamic field values in linked-tickets-tabl…
bbb2ff8 
…e. (znuny#300)

Co-authored-by: Denny Korsukéwitz <dennykorsukewitz@gmail.com>
Co-authored-by: Niklas <ns@znuny.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasSchmitt NiklasSchmitt NiklasSchmitt approved these changes

Assignees

@NiklasSchmitt NiklasSchmitt

Labels
1 - 🐞 bug 🐞 An issue with the system. 2 - Frontend 4 - verified This issue or pull request was verified.
Milestone
rel-7_0_9
Development

Successfully merging this pull request may close these issues.
3 participants
@tipue-dev @NiklasSchmitt @dennykorsukewitz