Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SectorNordAG: Fixed missing $ on StartDateTimeObject -> $StartDateTimeObject #475

Merged
merged 3 commits into from
Aug 7, 2023
Merged

SectorNordAG: Fixed missing $ on StartDateTimeObject -> $StartDateTimeObject #475

merged 3 commits into from
Aug 7, 2023

Conversation

LuBroering
Copy link
Contributor

@LuBroering LuBroering commented Aug 7, 2023 •
edited
Loading

Proposed change

Fixed a missing $ for StartDateTimeObject

  • '1 - 🐞 bug 🐞'

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

dennykorsukewitz
dennykorsukewitz requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@dennykorsukewitz dennykorsukewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuBroering ,
thanks for your PR.

Can you also please fix this here.
Kernel/System/GenericAgent/NotifyAgentGroupWithWritePermission.pm

Since 2017.

Regards 🚀

@dennykorsukewitz dennykorsukewitz added 1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified. 3 - wait for contributor Contributor, it's your turn. 1 - 💎 code quality Code quality improvements to existing code or addition of unit tests. 2 - Backend Znuny Feature labels Aug 7, 2023
@dennykorsukewitz dennykorsukewitz added this to the rel-7_0_10 milestone Aug 7, 2023
@dennykorsukewitz dennykorsukewitz added 3 - wait for merge Znuny, it's your turn. and removed 3 - wait for contributor Contributor, it's your turn. labels Aug 7, 2023
@dennykorsukewitz dennykorsukewitz merged commit 276f624 into znuny:dev Aug 7, 2023
11 of 14 checks passed
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for merge Znuny, it's your turn. label Aug 7, 2023
znuny-robo pushed a commit that referenced this pull request Aug 7, 2023
@LuBroering @dennykorsukewitz
SectorNordAG: Fixed missing $ on StartDateTimeObject -> $StartDateTim…
f853dd8 
…eObject (#475).

* Added $ to StartDateTimeObject Kernel/System/GenericAgent/NotifyAgentGroupWithWritePermission.pm
* Added $ to StartDateTimeObject Kernel/System/GenericAgent/NotifyAgentGroupOfCustomQueue.pm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennykorsukewitz dennykorsukewitz dennykorsukewitz approved these changes

Assignees

@dennykorsukewitz dennykorsukewitz

Labels
1 - 🐞 bug 🐞 An issue with the system. 1 - 💎 code quality Code quality improvements to existing code or addition of unit tests. 2 - Backend 4 - verified This issue or pull request was verified.
Milestone
rel-7_0_10
Development

Successfully merging this pull request may close these issues.
2 participants
@LuBroering @dennykorsukewitz