Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling whitespaces around '=' in Content-Type/charset token. #75

Merged
merged 14 commits into from
Aug 2, 2023

Conversation

pboguslawski
Copy link
Contributor

@pboguslawski pboguslawski commented May 13, 2021

Proposed change

This mod allowes Znuny to handle spaces around = in Content-Type/charset
like in message below:

Return-Path: <test@test.loc>
Date: Wed, 30 Apr 2014 12:04:07 +0200
From: test <test@test.loc>
To: <test@test.loc>
Subject: test
MIME-Version: 1.0
Content-Type: text/plain; charset = "utf-8"
Content-Transfer-Encoding: 8bit
Message-ID: <test1003@test.loc>

żółw

Extra spaces are tolerated by http://tools.ietf.org/tools/msglint/
validator (warnings only) and e-mail clients like Mozilla Thunderbird;
Znuny should allow it too to avoid problems (i.e. errors in syslog)
with e-mail messages using spaces as above.

Type of change

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Additional information

  • Author-Change-Id: IB#1015440

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy run passes successfully.(❕)
  • Local unit tests pass.(❕)
  • GitHub workflow ZnunyCodePolicy passes.(❗)
  • GitHub workflow unit tests pass.(❗)

This mod allowes Znuny to handle spaces around = in Content-Type/charset
like in message below:

    Return-Path: <test@test.loc>
    Date: Wed, 30 Apr 2014 12:04:07 +0200
    From: test <test@test.loc>
    To: <test@test.loc>
    Subject: test
    MIME-Version: 1.0
    Content-Type: text/plain; charset = "utf-8"
    Content-Transfer-Encoding: 8bit
    Message-ID: <test1003@test.loc>

    żółw

Extra spaces are tolerated by http://tools.ietf.org/tools/msglint/
validator (warnings only) and e-mail clients like Mozilla Thunderbird;
Znuny should allow it too.

Author-Change-Id: IB#1015440
@dennykorsukewitz dennykorsukewitz added 4 - clarification The issue or pull requests needs more information. 3 - wait for contributor Contributor, it's your turn. 2 - unknown labels May 19, 2021
@rkaldung
Copy link
Member

Hi @pboguslawski,

Please follow the contributing guidelines and use the pull request template. And also, please point out if this is a bug fix or a feature.

1 similar comment
@rkaldung
Copy link
Member

Hi @pboguslawski,

Please follow the contributing guidelines and use the pull request template. And also, please point out if this is a bug fix or a feature.

@pboguslawski
Copy link
Contributor Author

Done.

@dennykorsukewitz dennykorsukewitz changed the base branch from rel-6_0-dev to rel-6_1-dev June 1, 2021 08:40
@dennykorsukewitz
Copy link
Member

Hi @pboguslawski

we have changed our rules regarding copyright.
We therefore ask you to remove your newly added copyrights.

Znuny is an open fork of an existing software.
So we have to respect the already given copyright of the original creators.

New files will be licensed using the AGPL Version 3. 
If you contribute code to the Znuny project you will get mentioned in the pull request incl. the commit, 
in CHANGES.md and in AUTHORS.md. 
We will not mention you in the file you provided or changed. 
Your work is highly appreciated and acknowledged but you contribute it to the project 
and your copyright will pass on to the fork itself.

https://github.com/znuny/Znuny/blob/rel-6_1-dev/CONTRIBUTING.md#licensing-copyright-and-credits

@pboguslawski
Copy link
Contributor Author

Done.

@dennykorsukewitz dennykorsukewitz added 3 - wait for reviewer Znuny, it's your turn. and removed 3 - wait for contributor Contributor, it's your turn. labels Jun 15, 2021
@dennykorsukewitz dennykorsukewitz removed their assignment Dec 30, 2021
@rkaldung rkaldung requested a review from jepf May 17, 2023 09:19
@dignin dignin requested review from dennykorsukewitz and removed request for jepf July 12, 2023 09:38
@dignin dignin removed the 4 - clarification The issue or pull requests needs more information. label Jul 12, 2023
@dennykorsukewitz dennykorsukewitz self-assigned this Aug 1, 2023
@dennykorsukewitz dennykorsukewitz changed the title Fixed handling whitespaces around = in Content-Type/charset token Fixed handling whitespaces around '=' in Content-Type/charset token. Aug 1, 2023
@dennykorsukewitz dennykorsukewitz added 4 - verified This issue or pull request was verified. 3 - wait for merge Znuny, it's your turn. and removed 3 - wait for reviewer Znuny, it's your turn. labels Aug 1, 2023
Copy link
Member

@dennykorsukewitz dennykorsukewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pboguslawski ,
thanks for your PR.

Approved 👍

Regards 🚀

@dennykorsukewitz dennykorsukewitz merged commit c11e2a7 into znuny:dev Aug 2, 2023
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for merge Znuny, it's your turn. label Aug 2, 2023
@dennykorsukewitz dennykorsukewitz added this to the rel-7_0_10 milestone Aug 2, 2023
@pboguslawski pboguslawski deleted the rel-6_0-IB#1015440 branch September 5, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 2 - Backend 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

4 participants