Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAKE_LOCK Android permission is no longer necessary since GCM deprecation in favor of FCM #1494

Closed
sunweiyang opened this issue Jun 30, 2020 · 4 comments
Closed

WAKE_LOCK Android permission is no longer necessary since GCM deprecation in favor of FCM #1494

sunweiyang opened this issue Jun 30, 2020 · 4 comments
Assignees
@Dallas62

Comments

@sunweiyang
Copy link

Google's official docs for migrating from GCM to FCM recommends to remove WAKE_LOCK permission:
https://developers.google.com/cloud-messaging/android/android-migrate-fcm

Since wake locks incur a significant penalty to battery life, can this library's documentation be updated to reflect this move to FCM?
@Dallas62
Copy link
Collaborator

Hi @sunweiyang
Thanks for this, this will be updated 😉

@Dallas62 Dallas62 self-assigned this Jun 30, 2020
Dallas62 added a commit that referenced this issue Jun 30, 2020
@Dallas62
Remove WAKE_LOCK from documentation. #1494
0bfc74b
Dallas62 added a commit that referenced this issue Jul 6, 2020
@Dallas62
Merge branch 'dev'
e37552d 
* dev: (48 commits)
  Release v4.0.0.
  Use SecureRandom and remove `onNotification` call for Scheduled notifications when there is no user interation.
  Update CHANGELOG.md
  replaced java.util.Random with java.security.SecureRandom in RNPushNotification.java
  Remove WAKE_LOCK from documentation. #1494
  Add `onRegistrationError`.
  Allow override the channel name and description in App. Add the detection of blocked channels.
  Fix notif reference undefined.
  Fix typo.
  Add notification id to iOS if userInfo doesn't exist
  `userInfo` is now populated with id by default to allow operation based on `id`
  "@react-native-community/push-notification-ios": "^1.2.2"
  add docs
  add example button to log scheduled notifications
  bump @react-native-community/push-notification-ios to v1.2.1
  format date for  scheduled notifications object
  map scheduled local notifications to united return object for both platforms
  add missing getters for notification attributes
  change naming of notification params returned on android, return date in unix timestamp as before
  format android getScheduledLocalNotifications return object to match iOS return object
  ...
@Dallas62
Copy link
Collaborator

Dallas62 commented Jul 8, 2020

Hi, the release 4.0.0 of the library should solve this issue, feel free to reopen if something is missing 😉

@Dallas62 Dallas62 closed this as completed Jul 8, 2020
@yinka-optisoft
Copy link

It doesn't solve it. I'm presently using react-native-push-notification: "^6.0.0" and I do not get a push notification when the app is closed.

@Dallas62
Copy link
Collaborator

Dallas62 commented Jan 9, 2021

Hi,

You must create a channel, please read the readme for that.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dallas62 Dallas62

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dallas62 @sunweiyang @yinka-optisoft