Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add hooks to intent handling and bundle parsing #1819

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

cayleyh
Copy link
Contributor

@cayleyh cayleyh commented Jan 13, 2021

For #1801.

This adds hooks to allow easier customization of intent handling and bundle parsing behaviour on Android. This can be used to send notifications sent by 3rd party messaging management platforms that have custom message formats the same onNotification() JS codepath.

See discussion in #1801.

@Dallas62
Copy link
Collaborator

Hi @cayleyh

I will look into it ASAP.

Regards,

@cayleyh cayleyh force-pushed the intent-handling-hooks branch from 8392bb2 to b12f751 Compare January 13, 2021 23:15
@Dallas62
Copy link
Collaborator

Hi @cayleyh

Can you provide an exemple in the README.md ? Like the one in #1801 ?
Even if there is already many things inside the README and it needs refactor 😄. Because if this feature is not documented, this will not be reusable.

The batch exemple looks enough. A release will be made this week-end.

Regards,

@cayleyh
Copy link
Contributor Author

cayleyh commented Jan 14, 2021

For sure. I'll add an example to the README right away.

Allows easier customization of intent handling and bundle parsing behaviour on Android. This can be used to send notifications sent by 3rd party messaging management platforms that have custom message formats the same onNotification() JS codepath.
@cayleyh cayleyh force-pushed the intent-handling-hooks branch from b12f751 to c052494 Compare January 14, 2021 18:42
@cayleyh
Copy link
Contributor Author

cayleyh commented Jan 14, 2021

@Dallas62 I've added instructions to the README on the 2 separate cases we discussed in #1801.

@Dallas62 Dallas62 merged commit 359aeb0 into zo0r:dev Jan 16, 2021
@cayleyh cayleyh deleted the intent-handling-hooks branch January 26, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants