Fix Android 12 PendingIntent

[cristianoccazinsp]

Fix Android 12 (SDK 31) notifications due to missing PendingIntent flags.

Fixes #2129

I've tested this on a Pixel 5 with Android 12 and a RN app compiled with SDK 31. However, I've only tested local notifications, but I expect that the change should work across all notifications as it is very simple.

[Dallas62]

Hi @cristianoccazinsp
Thanks for your contributions !

[cristianoccazinsp]

Thanks for merging, I think I missed this line too: https://github.com/cristianoccazinsp/react-native-push-notification/blob/8d7ab959f574984bac7df50f5adb84bdb5e04b88/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotificationHelper.java#L531

@Dallas62 Can you update that line with the same logic before releasing?

[Dallas62]

Hi @cristianoccazinsp
This change affect some functionalities: #2152
Since I don't have time to investigate, do you have an idea ?

[cristianoccazinsp]

@Dallas62 I think the issue may be related to using PendingIntent.FLAG_IMMUTABLE instead of FLAG_MUTABLE. I don't currently have code that uses #2152 code, but perhaps @redexp or @TongManhCong can help testing the change.

[Dallas62]

@redexp @TongManhCong

You can try to change :
https://github.com/zo0r/react-native-push-notification/blob/master/android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotificationHelper.java#L536

by:

                    int flags = PendingIntent.FLAG_UPDATE_CURRENT;

                    if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
                      if(action.equals("ReplyInput")) {
                        flags = PendingIntent.FLAG_UPDATE_CURRENT | PendingIntent.FLAG_MUTABLE;
                      }
                      else {
                        flags = PendingIntent.FLAG_UPDATE_CURRENT | PendingIntent.FLAG_IMMUTABLE;
                      }
                    }

Regards

[cristianoccazinsp]

That seems like an even more reasonable fix, checking for reply input as well.

What are the side effects of marking an intent as mutable?

[ammarahm-ed]

The current fix has broken ReplyInput. reply_text is not returned by onAction because PendingIntent.FLAG_IMMUTABLE is set.

@Dallas62 PendingIntent.FLAG_MUTABLE was added in SDK 31. I think we will need a separate check for SDK 31.