Google play services versioning

[kingbin]

• Gradle fails to build with other modules requiring "apply plugin: 'com.google.gms.google-services'" in app-gradle.build. ie: FCM.

The error given is:

Gradle sync failed: For input string: "+"

• The change in this request adds the ability for a developer to pass in a version through a root project ext variable, googlePlayServicesVersion.

• This change adds functionality to the Gradle build and is not operating system specific.

• This change can be tested by adding FCM support to a project and then adding the apply plugin.
  app-gradle.build

...
dependencies {
    ...
    implementation project(':react-native-push-notification')
    implementation "com.google.firebase:firebase-core:$googlePlayServicesVersion"
    implementation "com.google.firebase:firebase-messaging:$googlePlayServicesVersion"
    ...
}
apply plugin: 'com.google.gms.google-services'
...

[systemride]

Just curious why this was closed? Do you have another solution?

[kingbin]

@systemride, I believe this request was automatically closed because I deleted my project branch. It would be awesome if this was accepted because I'm currently managing an internal fork of this project for a project I'm working on.

I wasn't really thinking that the pull request would be lost if I cleaned up my branches. I restored the branch and I'll make another pull request.

Sorry about that.

[systemride]

Awesome. I'd love to see this get merged in. I am unable to build on Android cleanly without something like this.

[systemride]

Actually, looks like there is another PR with the same fix: #684

[kingbin]

It'd be cool to get this in the repo and submitted to npm regardless of which pull request gets accepted.

[Gp2mv3]

The PR #684 does exactly the same thing and is indeed merged. 😉