-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor Apache X-Request-Start header containing microseconds #210
Honor Apache X-Request-Start header containing microseconds #210
Conversation
d48ac13
to
cc358d8
Compare
cc358d8
to
2799bae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I'd like to know the tests pass, and I haven't run them manually, and I'm not exactly sure how to get them to run on your PR.
@wuputah re: running the tests - after running |
Ah sorry, I mean here on GitHub (CI).There should really be an easier way to approve this. |
@wuputah ah, gotcha, my misunderstanding! |
If possible, can you rebase, force-push, and see if that lets me run the workflow? I think you wont need the changes in 7f78737 anymore. |
There's no bug in the implementation itself, but the tests are intermittently failing because
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix for time_in_usec
@wuputah thanks for seeing this one across the finish line |
At my work we recently switched to nginx from Apache, and were puzzled why we began seeing errors to do with rack-timeout's wait_timeout behavior when we hadn't before. We'd had the X-Request-Start header set on Apache for some time (years)
I tracked it down to the Apache-formatted header with microseconds, e.g. "t=" + 16 digits like
t=1700173924763384
, not being honored, as mentioned here.This PR adds that capability, with a test, and also adds notes to docs/settings.md, UPGRADING.md, and CHANGELOG.md
First commit contains two lines I needed to add to be able to run the project's tests with
rake
.