Allow pipe commands to start with $ #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipe commands can take two forms:
and:
So that fully qualified commands can be used. There was a bug that commands that started with $ were not being used.
Prior to this the parser was expecting a
command
which looks like this:Which would never be matched. So we were accidentally relying on the failure rescue mode from the parser to give us the behavior for
| tail
.With this change any commands should be allowed such as
| $ tail
.