Preserve partial doc results on failure #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a command failed you lose the resulting doc, including everything up to that point which might be salvalgable. With this change a partial result is written to disk on failure.
schneems
force-pushed
the
schneems/partial-render-too
branch
from
66456f4 to
1c483a6
Compare
schneems
added a commit
that referenced
this pull request
Nov 20, 2024
The prior PR #69 mistakenly only preserved the last command to be executed instead of the document up to that point. This commit fixes the tests by introducing partial result storage and retrieval to the class that builds and calls the individual CodeSections
schneems
added a commit
that referenced
this pull request
Nov 20, 2024
The prior PR #69 mistakenly only preserved the last command to be executed instead of the document up to that point. This commit fixes the tests by introducing partial result storage and retrieval to the class that builds and calls the individual CodeSections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a command failed you got to keep the directory it generated, but any of the docs were lost. This change introduces a way to store partial results and retrieve them on failure. It's tested and seems to work. So that's nice.