Fix: Website commands now use lazy lookup #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supporting `pre.erb` means that any lookups need to happen at the last possible moment. Websites have a name lookup feature similar to background tasks. Background tasks adopted a lazy lookup model in `4.1.2`. Ensuring these are all covered under test: - `website.screenshot` is covered: ``` 1) Error: SystemsCliTest#test_screenshots_dir: 2) Error: IntegrationWebsiteTest#test_screenshot_command: ``` - `website.visit` is covered ``` 1) Error: SystemsCliTest#test_screenshots_dir: 2) Error: IntegrationWebsiteTest#test_screenshot_command: ``` - `website.navigate` is not covered. Adding a call to the integration test so it's at last exercised
schneems
force-pushed
the
schneems/delayed-website
branch
from
d702e3f to
c7b013c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting
pre.erbmeans that any lookups need to happen at the last possible moment. Websites have a name lookup feature similar to background tasks. Background tasks adopted a lazy lookup model in4.1.2.Ensuring these are all covered under test:
website.screenshotis covered:website.visitis coveredwebsite.navigateis not covered. Adding a call to the integration test so it's at last exercised