-
-
Notifications
You must be signed in to change notification settings - Fork 212
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: addListener/removeListeners native stubs for react-native 0.65 c…
…ompatibility Thanks to react-native-device-info/react-native-device-info#1288
- Loading branch information
Showing
3 changed files
with
19 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
168dd8a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For iOS, it is most likely not required, and will in fact cause issues. Can you revert the iOS change?
@mikehardy
168dd8a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @zoontek this is an area of active investigation, it appears on iOS adding stubs here disrupts listener behavior in netinfo module at least react-native-netinfo/react-native-netinfo#493 - but no repo (that I know of) actually has an e2e test rigged up where one of these listeners is exercised on iOS so it's all just user reports at the moment. That said, consistent user reports, so I'm going to reverse the stubs on iOS for netinfo at least. I don't personally have time to dig deep on this at the moment unfortunately
168dd8a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a rollback