-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visionOS support #253
Merged
Merged
Add visionOS support #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Saadnajmi Perfect, thanks a lot! |
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 30, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-localize](https://togithub.com/zoontek/react-native-localize) | [`^2.2.6` -> `^3.1.0`](https://renovatebot.com/diffs/npm/react-native-localize/2.2.6/3.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-localize/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-localize/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-localize/2.2.6/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-localize/2.2.6/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>zoontek/react-native-localize (react-native-localize)</summary> ### [`v3.1.0`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.1.0) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.6...3.1.0) - Add visionOS support by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/zoontek/react-native-localize/pull/253](https://togithub.com/zoontek/react-native-localize/pull/253) ### [`v3.0.6`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.6) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.5...3.0.6) - Update mock and testing instructions ### [`v3.0.5`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.5) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.4...3.0.5) - Add Android Gradle plugin 8 compatibility - Fix `AndroidManifest.xml` namespace deprecation warning ### [`v3.0.4`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.4) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.3...3.0.4) - Remove duplicate `RNLocalizeSpec.h` import when new architecture is enabled (fix [#​238](https://togithub.com/zoontek/react-native-localize/issues/238)) ### [`v3.0.3`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.3) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.2...3.0.3) - Use [`LocaleListCompat.getDefault()`](https://developer.android.com/reference/androidx/core/os/LocaleListCompat#getDefault\(\)) to fix preferred languages list order in some rare cases (fix [#​236](https://togithub.com/zoontek/react-native-localize/issues/236)) ### [`v3.0.2`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.2) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.1...3.0.2) - Use gradle `namespace` conditionally in order to improve old react native version compatibility. *⚠️ Note that this library officially now follows the React Native [releases support policy](https://togithub.com/reactwg/react-native-releases#releases-support-policy). If you have been impacted by this bug, that means you are using an unsupported react native version and should upgrade to the latest.* ### [`v3.0.1`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.1) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.0...3.0.1) - Add gradle `namespace` for react native 0.73 compatibility ### [`v3.0.0`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.0) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/2.2.6...3.0.0) #### 3.0.0: New architecture support 🎉 This release come with a huge change underneath: Instead of constants, the library now perform synchronous methods calls (on both old and new architecture), which means the returned informations will always be up-to-date (fixes [https://github.com/zoontek/react-native-localize/issues/186](https://togithub.com/zoontek/react-native-localize/issues/186)). This also means that remote debugging (e.g. with Chrome) is no longer possible and that you should switch to [Flipper 🐬](https://fbflipper.com) (an acceptable trade-off as remote debugging isn't possible with the new architecture anyway) ##### Other changes: - Drop support for: - `react-native-windows` (temporarily) - `react-native`, `react-native-macos` < 0.70 - `react-native-web` < 0.18 - Android < 5 - iOS and tvOS < 12.4 - Remove `addEventListener` as you can now safely rely on [`AppState` ](https://reactnative.dev/docs/appstate)and get the possible new value when app become `active` (fixes [https://github.com/zoontek/react-native-localize/issues/91](https://togithub.com/zoontek/react-native-localize/issues/91)) - `getCalendar` can now return all supported macOS calendars (`buddhist`, `coptic`, `ethiopic`, `hebrew`…) - `findBestAvailableLanguage` has been renamed `findBestLanguageTag` - Package default export has been removed. If you really want to import everything, use `import * as Localize from "react-native-localize"` instead </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
shottah
referenced
this pull request
in zed-io/kolektivo
May 15, 2024
…5310) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-localize](https://togithub.com/zoontek/react-native-localize) | [`^2.2.6` -> `^3.1.0`](https://renovatebot.com/diffs/npm/react-native-localize/2.2.6/3.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-localize/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-localize/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-localize/2.2.6/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-localize/2.2.6/3.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>zoontek/react-native-localize (react-native-localize)</summary> ### [`v3.1.0`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.1.0) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.6...3.1.0) - Add visionOS support by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/zoontek/react-native-localize/pull/253](https://togithub.com/zoontek/react-native-localize/pull/253) ### [`v3.0.6`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.6) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.5...3.0.6) - Update mock and testing instructions ### [`v3.0.5`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.5) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.4...3.0.5) - Add Android Gradle plugin 8 compatibility - Fix `AndroidManifest.xml` namespace deprecation warning ### [`v3.0.4`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.4) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.3...3.0.4) - Remove duplicate `RNLocalizeSpec.h` import when new architecture is enabled (fix [#​238](https://togithub.com/zoontek/react-native-localize/issues/238)) ### [`v3.0.3`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.3) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.2...3.0.3) - Use [`LocaleListCompat.getDefault()`](https://developer.android.com/reference/androidx/core/os/LocaleListCompat#getDefault\(\)) to fix preferred languages list order in some rare cases (fix [#​236](https://togithub.com/zoontek/react-native-localize/issues/236)) ### [`v3.0.2`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.2) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.1...3.0.2) - Use gradle `namespace` conditionally in order to improve old react native version compatibility. *⚠️ Note that this library officially now follows the React Native [releases support policy](https://togithub.com/reactwg/react-native-releases#releases-support-policy). If you have been impacted by this bug, that means you are using an unsupported react native version and should upgrade to the latest.* ### [`v3.0.1`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.1) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/3.0.0...3.0.1) - Add gradle `namespace` for react native 0.73 compatibility ### [`v3.0.0`](https://togithub.com/zoontek/react-native-localize/releases/tag/3.0.0) [Compare Source](https://togithub.com/zoontek/react-native-localize/compare/2.2.6...3.0.0) #### 3.0.0: New architecture support 🎉 This release come with a huge change underneath: Instead of constants, the library now perform synchronous methods calls (on both old and new architecture), which means the returned informations will always be up-to-date (fixes [https://github.com/zoontek/react-native-localize/issues/186](https://togithub.com/zoontek/react-native-localize/issues/186)). This also means that remote debugging (e.g. with Chrome) is no longer possible and that you should switch to [Flipper 🐬](https://fbflipper.com) (an acceptable trade-off as remote debugging isn't possible with the new architecture anyway) ##### Other changes: - Drop support for: - `react-native-windows` (temporarily) - `react-native`, `react-native-macos` < 0.70 - `react-native-web` < 0.18 - Android < 5 - iOS and tvOS < 12.4 - Remove `addEventListener` as you can now safely rely on [`AppState` ](https://reactnative.dev/docs/appstate)and get the possible new value when app become `active` (fixes [https://github.com/zoontek/react-native-localize/issues/91](https://togithub.com/zoontek/react-native-localize/issues/91)) - `getCalendar` can now return all supported macOS calendars (`buddhist`, `coptic`, `ethiopic`, `hebrew`…) - `findBestAvailableLanguage` has been renamed `findBestLanguageTag` - Package default export has been removed. If you really want to import everything, use `import * as Localize from "react-native-localize"` instead </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add visionOS support by adding the platform to the podspec
Test Plan
Normally, I would update the test app to use react-native-test-app, which I added visionOS support to. However, that test app doesn't support web, and I see there is a web example in this repo. I did however, test localize in a different packages' test app on visionOS by patching the package: react-native-datetimepicker/datetimepicker#879
And it compiled fine :)
Compatibility
Checklist
README.md
example/src/App.js
)