Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Opening the
android
folder in Android Studio (or attempting to build it on command line) results in the following error:The reason was a missing
buildscripts
section inandroid/build.gradle
. However, since the Android Gradle plugin is only required when opening the project stand-alone, the dependency was wrapped in a conditional:By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).
A couple of other dependency fixes were required as well:
com.facebook.react:react-native:+
is supposed to be included and resolved from a local path innode_modules
. Therefore it needs to be added to thedevDependencies
section of the project. Without it, Gradle would pick the latest version of React Native from Maven Central: 0.20.1 from Feb 2016 😱.Test Plan
What's required for testing (prerequisites)?
Android Studio and/or Gradle installed locally.
What are the steps to reproduce (after prerequisites)?
Open
android
in Android Studio:Or:
Generate a Gradle wrapper on the fly, and build on command line:
cd android/ gradle wrapper --gradle-version 5.4.1 --distribution-type all ./gradlew build
Successfully verified and tested on:
Compatibility
Checklist
README.md
(N/A)CHANGELOG.md
(N/A)example/App.js
) (N/A)