Improved error handling for "Attempt to invoke interface method 'void com.facebook.react.bridge.Callback.invoke(java.lang.Object[])'" on com.zoontek.rnpermissions.RNPermissionsModule.onRequestPermissionsResult

[webraptor]

Summary

This PR further extends on some crash reports that we've seen for android users in production environments, which were already handled and reduced in occurrences by #805 and 63b695a

Compatibility

OS	Implemented
iOS	✅
Android	✅

Checklist

• I have tested this on a device and a simulator
• tested in live/production environment using PRs fork as source

[webraptor]

@zoontek any idea when you could look into this PR?

[zoontek]

@webraptor I think it would be better to simplify it to only this (and catch all exceptions, without custom messages are the Exception e details are logged anyway):

try {
  mCallbacks.get(requestCode).invoke(grantResults, getPermissionAwareActivity());
  mCallbacks.remove(requestCode);
  return mCallbacks.size() == 0;
} catch (Exception e) {
  FLog.e(
    "PermissionsModule",
    e,
    "Unexpected invocation of `onRequestPermissionsResult`");
  return false;
}

[webraptor]

Yeah @zoontek, that would work as well. Wasn't sure if anyone else might want the more detailed exception catching.

I'll update the PR shortly so it's easier to merge.

[webraptor]

@zoontek PR code updated. Thanks

[zoontek]

@webraptor Thanks, I will have a look and release this weekend.

[zoontek]

Sorry, I was not personally available (at least had no free time) until now. I merge this is a 4.1.0 for more testing before a release, thanks a lot!

[zoontek]

Done, thanks! https://github.com/zoontek/react-native-permissions/releases/tag/4.1.0