Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the inspect PR. #256

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Improve the inspect PR. #256

merged 1 commit into from
Jul 17, 2023

Conversation

icemac
Copy link
Member

@icemac icemac commented Jul 10, 2023

As the PR is already merged here a PR to improve it a bit further.

@icemac
Improve the inspect PR.
3487449 
As the PR is already merged here a PR to improve it a bit further.
@icemac icemac requested review from dataflake and loechel July 10, 2023 06:12
dataflake
dataflake approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I hope Alexander has time to take a look as well.

@icemac icemac merged commit 5aca797 into master Jul 17, 2023
@icemac icemac deleted the inspect-improvements branch July 17, 2023 05:45
@icemac
Copy link
Member Author

icemac commented Jul 17, 2023

Thank you for reviewing this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

@loechel loechel Awaiting requested review from loechel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icemac @dataflake