Raise generic errors (catch all InternalError) when using WSGI #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschorr
changed the title
icemac
approved these changes
May 18, 2018
There was a problem hiding this comment.
LGTM, I like this change!
I tested it against the test browser tests of five.localsitemanager. The behaviour seems reasonable.
In an actual browser the traceback is sent to the console instead of omitting it and the error message displayed to the user no longer contains hints about the error.
Could you do something against the drop in coverage to make this PR perfect?
|
@icemac thanks for clarifying the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imho it makes sense to propagate errors to the WSGI server in order to make use of the configured logging facilities.