-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary support for Python 3.14a2. #335
Conversation
I can see the fix for that missing Also, if you only want to test "is this Python 3.14", why do you need all those definitions for the older versions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you remove the IByteString
definitions (in common.builtins
and common.collections
) for Python 3.14? The interface is likely useful for that version as well.
Python 3.14 removed
|
@d-maurer |
I have applied a suggestion for a simpler version check in 1f6009f - feel free to revert if you don't agree. I am not sure what to do about the ByteString issue because I don't know if or how widespread the use of that interface is. |
Michael Howitz wrote at 2024-11-26 23:56 -0800:
> Why do you remove the `IByteString` definitions (in `common.builtins` and `common.collections`) for Python 3.14? The interface is likely useful for that version as well.
@d-maurer
I did not see an obvious way to keep it after Python 3.14 removed `collections.abs.ByteString`, see [ByteString](https://docs.python.org/3/library/collections.abc.html#collections.abc.ByteString) – maybe you find one.
Convinced! I was unaware of this change in Python 3.14.
|
Thank you for reviewing this PR. 😃 |
I hacked something together so the tests do not fail for Python 3.14.
But I am completly unsure if this is the way we want/should go.
Fixes #334.