Validate that a plugin adds commands, overrides, or both, but fails i…

…f it has neither. Signed-off-by: Gene Johnston <Eugene.Johnston@ca.com>
zowe · Sep 17, 2018 · e2d4236 · e2d4236
1 parent ca28135
commit e2d4236
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/imperative/src/plugins/PluginManagementFacility.ts b/packages/imperative/src/plugins/PluginManagementFacility.ts
@@ -973,9 +973,16 @@ export class PluginManagementFacility {
                     ".pluginHealthCheck' property does not exist: " + healthChkFilePath);
             }
         }
-        if (!pluginCmdGroup.children || pluginCmdGroup.children.length <= 0) {
+
+        /* If a plugin does neither of the following actions, we reject it:
+         *   - define commands
+         *   - override an infrastructure component
+         */
+        if ((!pluginCmdGroup.children || pluginCmdGroup.children.length <= 0) &&
+            (!pluginCfgProps.impConfig.overrides || Object.keys(pluginCfgProps.impConfig.overrides).length <= 0))
+        {
             this.pluginIssues.recordIssue(pluginCfgProps.pluginName, IssueSeverity.ERROR,
-                "The plugin's configuration defines no children.");
+                "The plugin defines no commands and overrides no framework components.");
         } else {
             // recursively validate the plugin's command definitions
             this.validatePluginCmdDefs(pluginCfgProps.pluginName, pluginCmdGroup.children);

diff --git a/packages/imperative/src/plugins/cmd/validate/validate.handler.ts b/packages/imperative/src/plugins/cmd/validate/validate.handler.ts
@@ -101,7 +101,7 @@ export default class ValidateHandler implements ICommandHandler {
       let msgColor: string = "yellow";
       if (this.pluginIssues.doesPluginHaveError(pluginName)) {
         msgColor = "red";
-        valResultsMsg += "No commands from this plugin will be available for future commands.\n";
+        valResultsMsg += "No operations from this plugin will be available for future commands.\n";
       }
 
       cmdResponse.console.log(TextUtils.chalk[msgColor](valResultsMsg));