-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
tucker01
commented
Oct 4, 2018
- Removes the requirement for Keytar in a CLI.
- Keytar is moved to a dev dependency in imperative.
- A CLI implementation can enable securing credentials by including keytar in their dependencies.
- Secured profile fields in the yaml file will read "managed by " if credentials are managed by keytar or a plugin
Signed-off-by: tucja02 <jason.tucker@ca.com>
…nto enhancement/28
…ored insecurely Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
…by [name]" Signed-off-by: Ly,Lam <lyzla01@ca.com>
Signed-off-by: Ly,Lam <lyzla01@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
…nto enhancement/28
…e of app settings?
Signed-off-by: tucja02 <jason.tucker@ca.com>
…tead of coupling the CliProfileManager with AppSettings Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
…ntegration tests Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question. Could the following piece of code
packages/profiles/src/BasicProfileManager.ts
88: parms.productDisplayName = (isNullOrUndefined(parms.productDisplayName)) ? "" : parms.productDisplayName;
result in an empty productDisplayName string being stored in a profile which would look like the line below?
password: managed by
I don't think that line should have effect on credential managers and profiles. It's all done via the CliProfileManager and OverridesLoader/CredentialManagerFactory... I refactored some code to set the managed by name and I must have missed some stuff that was done previously. Thanks for pointing this out. Let me take a peek and see what's what. |
Sorry for the confusion here. I removed those changes. I should have looked more closely at what was already done... I offered to complete the changes when the team member working on it was asked to help elsewhere. I refactored where the display name gets supplied (to decouple some internal packages). @ChrisBoehmCA is making a PR to update the sample zowe-cli plugin with the changes required. |