Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Enhancement/28 #35

Merged
42 commits merged into from
Oct 8, 2018
Merged

Enhancement/28 #35

42 commits merged into from
Oct 8, 2018

Conversation

tucker01
Copy link
Contributor

@tucker01 tucker01 commented Oct 4, 2018

  • Removes the requirement for Keytar in a CLI.
  • Keytar is moved to a dev dependency in imperative.
  • A CLI implementation can enable securing credentials by including keytar in their dependencies.
  • Secured profile fields in the yaml file will read "managed by " if credentials are managed by keytar or a plugin

tucker01 and others added 30 commits September 27, 2018 08:47
Signed-off-by: tucja02 <jason.tucker@ca.com>
…ored insecurely

Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
…by [name]"

Signed-off-by: Ly,Lam <lyzla01@ca.com>
Signed-off-by: Ly,Lam <lyzla01@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
…tead of coupling the CliProfileManager with AppSettings

Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
…ntegration tests

Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
@tucker01 tucker01 requested a review from gejohnston October 4, 2018 19:29
@ghost ghost assigned tucker01 Oct 4, 2018
@ghost ghost added in progress labels Oct 4, 2018
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question. Could the following piece of code

packages/profiles/src/BasicProfileManager.ts
    88:  parms.productDisplayName = (isNullOrUndefined(parms.productDisplayName)) ? "" : parms.productDisplayName;

result in an empty productDisplayName string being stored in a profile which would look like the line below?

password: managed by 

@tucker01
Copy link
Contributor Author

tucker01 commented Oct 5, 2018

I don't think that line should have effect on credential managers and profiles. It's all done via the CliProfileManager and OverridesLoader/CredentialManagerFactory... I refactored some code to set the managed by name and I must have missed some stuff that was done previously.

Thanks for pointing this out. Let me take a peek and see what's what.

Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
Signed-off-by: tucja02 <jason.tucker@ca.com>
@tucker01
Copy link
Contributor Author

tucker01 commented Oct 8, 2018

Sorry for the confusion here. I removed those changes. I should have looked more closely at what was already done... I offered to complete the changes when the team member working on it was asked to help elsewhere.

I refactored where the display name gets supplied (to decouple some internal packages).

@ChrisBoehmCA is making a PR to update the sample zowe-cli plugin with the changes required.

@ghost ghost merged commit 8ca1488 into master Oct 8, 2018
@ghost ghost deleted the enhancement/28 branch October 8, 2018 14:58
@ghost ghost removed in progress labels Oct 8, 2018
@ghost ghost mentioned this pull request Oct 8, 2018
@ghost ghost assigned PeteSwauger Nov 13, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants