Array with allowable values

[liuxh0]

#428

[codecov]

Codecov Report

Merging #429 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   81.82%   81.80%   -0.02%     
==========================================
  Files         157      157              
  Lines        7764     7613     -151     
  Branches     1419     1374      -45     
==========================================
- Hits         6353     6228     -125     
+ Misses       1407     1381      -26     
  Partials        4        4              

Impacted Files	Coverage Δ
packages/cmd/src/syntax/SyntaxValidator.ts	80.05% <100.00%> (-0.80%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d6e57...cd3e4ed. Read the comment docs.

[ghost]

LGTM. Please merge the latest changes from master into your branch.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

The version of Java (1.8.0_212) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

[scifipony]

Please ensure in testing that an array of no elements (an option with no argument) is not flagged in error if allowableValues is not coded, or this will be a breaking change.

[liuxh0]

Hi @scifipony , I am not really sure what you mean.

The scenario you described will be flagged in error because an array is expected but a boolean is provided. The behavior is exactly the same before my change. Why this is a breaking change?

However in Zowe, an array-type option with no argument will result in an empty array instead of a boolean true. I am not familiar but I assume Zowe did some error handling.

[scifipony]

@liuxh0

in Zowe, an array-type option with no argument will result in an empty array instead of a boolean true.

Correct.

I assume Zowe did some error handling

Best I can tell, it does not. It certainly does not flag as in-error an array-type option with no argument. I want to ensure that this behavior continues. Should Zowe start flagging it, it would be a breaking change for my product.

[liuxh0]

@scifipony
I am still a little bit confused. Before and after, the behavior is the same. How can I help here?

[scifipony]

@scifipony
I am still a little bit confused. Before and after, the behavior is the same. How can I help here?

All I was asking to ensure the behavior didn't change. If the behavior is the same "before and after" the changes you made, then everything is fine.

[zFernand0]

LGTM