Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Fix single character options rendered in help with double dash #742

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix single character options rendered in help with double dash #742

merged 1 commit into from
Mar 4, 2022

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Mar 3, 2022

Fixes #638

@t1m0thyj
Fix single character options rendered in help with double dash
4468be0 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #742 (4468be0) into master (f86200d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   82.52%   82.57%   +0.05%     
==========================================
  Files         163      163              
  Lines        7931     7931              
  Branches     1400     1401       +1     
==========================================
+ Hits         6545     6549       +4     
+ Misses       1382     1378       -4     
  Partials        4        4
Impacted Files Coverage Δ
...ges/cmd/src/help/abstract/AbstractHelpGenerator.ts 93.13% <100.00%> (ø)
packages/cmd/src/response/CommandResponse.ts 97.04% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0003e89...4468be0. Read the comment docs.

zFernand0
zFernand0 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@t1m0thyj t1m0thyj merged commit 7795f98 into master Mar 4, 2022
@t1m0thyj t1m0thyj deleted the fix-help-single-char-opts branch March 4, 2022 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@awharn awharn awharn approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@gejohnston gejohnston gejohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single character options accessed w/ single dash (correct) but rendered in help w/ double-dash (incorrect)
4 participants
@t1m0thyj @gejohnston @zFernand0 @awharn