Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia: Trying to add a pre-existing profile to a view leads to new profile creation #1009

Closed
lauren-li opened this issue Sep 8, 2020 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@lauren-li
Copy link
Contributor

As of Theia v1.1.0, a change has been implemented in the way Theia returns env.appName. Instead of just returning "Eclipse Theia" like before (which Zowe Explorer relied on for its globals.ISTHEIA check), Theia now uses the plugin's applicationName in its package.json to dynamically return the value for the plugin's env.appName.

Below are steps to recreate just one example instance of a Theia compatability issue, although there are others.

To Reproduce

  1. Run Zowe Explorer in Theia Browser Example.
  2. In the Data Sets view (or any tree view), click the + button to add a pre-existing profile to the view.
  3. In the dialog for adding a profile, use your mouse select any pre-existing profile from the drop-down list.
  4. See that Zowe Explorer acts as if no profile was selected, and guides you to new profile creation.

There is already code to properly handle this and to provide additional Zowe Explorer compatability with Theia, but as of Theia v1.1.0, it is not getting called because globals.ISTHEIA is set to false.

Expected behavior
Zowe Explorer is able to correctly detect Theia instances and call on code to provide Theia compatability.

Desktop (please complete the following information):

  • OS: MacOS
  • Zowe Explorer Version: 1.8.0
  • (Optional) Zowe CLI Version:
  • (Optional) Are you using Secure Credential Store?
@lauren-li lauren-li added the bug Something isn't working label Sep 8, 2020
@zFernand0 zFernand0 added this to the 1.9 Release milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants