Update environment check for Theia compatability

[lauren-li]

Proposed changes

Fixes issue #1009 and restores general Theia compatability.

Release Notes

Milestone: 1.9.0

Changelog: Update environment check for Theia compatability.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• npm run vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

[phaumer]

I tested this fix successfully in VS Code, Theia 1.3, and CRW 2.3 (which is Che 7.16.2)

[crawr]

Thanks for fixing this. I wonder if instead of hard-coding the value "2", will vscode detect the variable vscode.UIKind.Web instead?

I tested several of the Theia branching code that we have (copy path, merge conflict, filter prompt, etc) and they all worked as expected.

[lauren-li]

@crawr Yes, vscode.UIKind.Web does work. Let's use that instead.

(I didn't use it earlier because my capitalization was uiKind instead of UIKind when I was trying this, and thus it wasn't working for me. Thanks for pointing this out!)

[codecov]

Codecov Report

Merging #1010 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          50       50           
  Lines        4830     4830           
  Branches      852      852           
=======================================
  Hits         4425     4425           
  Misses        403      403           
  Partials        2        2           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027db5e...99dfe31. Read the comment docs.

[lauren-li]

@crawr @phaumer Thank you for testing out this PR! I have updated it according to @crawr's suggestion, and it is ready to be reviewed again.

[phaumer]

Retested and it still works.

[crawr]

LGTM!