-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 1127: Pre-select existing reject unauthorized value for update profile #1218
Conversation
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is smart! Thank you @JillieBeanSim 👍
…zowe/vscode-extension-for-zowe into 1127-ru-prefilled-value-editing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me! All unit and expected integration tests are passing. I tested this manually with creating a new profile (rejectUnauthorized defaults to true, as it should). I also tested editing different profiles with rejectUnauthorized values of true and false, and the functionality to use the existing value as the pre-selected option is working well.
Thanks @JillieBeanSim for this fix! It will make the UX of editing profiles much smoother!
Signed-off-by: Billie Simmons 49491949+JillieBeanSim@users.noreply.github.com
Proposed changes
This will pre-fill the placeholder with a previously chosen
rejectUnauthorized
value as well as bring that selection to the top of the list and is highlighted to be entered passed or changed by user when editing a profile. Creating a profile the placeholder is the same as before as well as the selection order.Release Notes
Milestone: 1.13.0
Changelog: Bugfix to pre-select existing value for rejectUnauthorized and show existing value in the quickPick placeholder so it can be entered by unless user decides to change the value.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...