Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 1127: Pre-select existing reject unauthorized value for update profile #1218

Merged
merged 6 commits into from
Mar 8, 2021

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Mar 2, 2021

Signed-off-by: Billie Simmons 49491949+JillieBeanSim@users.noreply.github.com

Proposed changes

This will pre-fill the placeholder with a previously chosen rejectUnauthorized value as well as bring that selection to the top of the list and is highlighted to be entered passed or changed by user when editing a profile. Creating a profile the placeholder is the same as before as well as the selection order.

leading-selected-RU

Release Notes

Milestone: 1.13.0

Changelog: Bugfix to pre-select existing value for rejectUnauthorized and show existing value in the quickPick placeholder so it can be entered by unless user decides to change the value.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link
Contributor

@jellypuno jellypuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is smart! Thank you @JillieBeanSim 👍

@crawr crawr requested a review from lauren-li March 4, 2021 13:03
Copy link
Contributor

@lauren-li lauren-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me! All unit and expected integration tests are passing. I tested this manually with creating a new profile (rejectUnauthorized defaults to true, as it should). I also tested editing different profiles with rejectUnauthorized values of true and false, and the functionality to use the existing value as the pre-selected option is working well.

Thanks @JillieBeanSim for this fix! It will make the UX of editing profiles much smoother!

@lauren-li lauren-li merged commit f87102d into master Mar 8, 2021
@lauren-li lauren-li deleted the 1127-ru-prefilled-value-editing branch March 8, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reject Unauthorized Value defaults back to true when editing profile
3 participants