Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read File Sync with proper require #545

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

Martin-Zeithaml
Copy link
Contributor

Proposed changes

The message ZWED0159E - Could not read zowe manifest, version unknown is generated due to wrong require function:

      let contents = fsPromises.readFileSync(path.join(zoweConfig.zowe.runtimeDirectory, 'manifest.json'), {encoding: 'utf8'});  
                                ^                                                                   
TypeError: fsPromises.readFileSync is not a function                                                

Fixes:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings

Testing

No ZWED0159E with fix.

CHANGELOG: The message "ZWED0159E - Could not read zowe manifest, version unknown" is no longer printed always
VERSION 2.16.0

Signed-off-by: Martin Zeithaml <Martin.Zeithaml@broadcom.com>
@1000TurquoisePogs 1000TurquoisePogs merged commit 4555e87 into v2.x/staging Apr 12, 2024
4 of 5 checks passed
@Martin-Zeithaml Martin-Zeithaml deleted the readManifest branch May 3, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants