Add new stage arguments #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
zFernand0
approved these changes
Jul 8, 2021
| @@ -926,7 +934,11 @@ class NodeJSPipeline extends GenericPipeline { | |||
| branch = changeInfo.branchName | |||
| } | |||
|
|
|||
| steps.sh "npm install" | |||
| if (arguments.customInstallScript) { | |||
| steps.sh "npm run ${arguments.customInstallScript}" | |||
There was a problem hiding this comment.
This assumes that the script has to be inlucede in the package.json#scripts object.
Wondering if it's be good if customInstallScript == "${one-liner shell script}"
It could potentially lead to other problems, (like not properly quoting something)
So, Not a good idea 😋
awharn
approved these changes
Jul 8, 2021
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeline.setup- "customInstallScript" to specify an NPM script to run in place of "npm install"pipeline.version- "inDir" to specify a subdirectory where "npm version" should be runpipeline.publish- "inDir" to specify a subdirectory where "npm publish" should be run