Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon Mode - Test/fix changing current directory when multiple requests come in simultaneously #1180

Closed
MikeBauerCA opened this issue Oct 26, 2021 · 1 comment

Comments

@MikeBauerCA
Copy link
Contributor

Test and fix changing current directory (and process environment) when multiple requests come in simultaneously.

@t1m0thyj
Copy link
Member

Resolved in #1317 and #1322. Interleaved requests are now queued (see #1178 (comment)). This should eliminate any race conditions related to accessing current directory and environment variables in command handlers. Additionally, we stopped recommending use of process.stdin (use IHandlerParameters.stdin instead) since it only supports a one-time read operation. If we decide to support multithreaded concurrent requests in the future, we will need to revisit how we handle these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants