Limit Daemon Concurrency on Windows #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Codecov Report
@@ Coverage Diff @@
## next #1322 +/- ##
==========================================
+ Coverage 91.39% 91.49% +0.09%
==========================================
Files 369 369
Lines 5752 5748 -4
Branches 826 824 -2
==========================================
+ Hits 5257 5259 +2
+ Misses 489 483 -6
Partials 6 6
Continue to review full report at Codecov.
|
t1m0thyj
reviewed
Feb 23, 2022
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
t1m0thyj
previously approved these changes
Feb 24, 2022
zFernand0
previously approved these changes
Feb 24, 2022
gejohnston
previously approved these changes
Feb 24, 2022
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
dismissed stale reviews from gejohnston, zFernand0, and t1m0thyj
via
0fed8dd
|
Kudos, SonarCloud Quality Gate passed!
|
t1m0thyj
approved these changes
Feb 24, 2022
zFernand0
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the implementation of named pipes in Windows, it is not possible to determine if another daemon client is talking to the daemon server using the named pipes alone. Instead, this PR introduces a 'lock file' that is locked when a client is communicating with the server, and released when the client is finished. The lock file's location can be overridden with the ZOWE_DAEMON_LOCK environment variable.