Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Imperative to resolve line-break issues in the web-help #1275

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Update Imperative to resolve line-break issues in the web-help #1275

merged 5 commits into from
Jan 19, 2022

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Jan 18, 2022 •
edited
Loading

@zFernand0
Update imperative to resolve line-breaks in web-help
8a7f488 
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@zFernand0
update package-lock
a9fc642 
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@zFernand0
updated npm-run-update-imperative script
24cd8b2 
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
t1m0thyj
t1m0thyj approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the lerna clean -y to prevent unnecessary package-lock changes 🙂

@zFernand0
Copy link
Member Author

Thanks for adding the lerna clean -y to prevent unnecessary package-lock changes 🙂

I also added npm i at the end in order to update the top level pacakge-lock
Maybe I could've done npm i --package-lock-only ?

Also, forgot to update snapshots 😢

@zFernand0
Update snapshots?
ab69ce3 
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
t1m0thyj
t1m0thyj reviewed Jan 18, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@zFernand0
Update umpdate:imperative script
5cfc700 
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zFernand0
Copy link
Member Author

Waiting on decision about possible breaking change 😢

@zFernand0
Copy link
Member Author

Waiting on decision about possible breaking change 😢

Good to go as a patch release 😋

@zFernand0 zFernand0 merged commit ccd2543 into master Jan 19, 2022
@zFernand0 zFernand0 deleted the imperative-715 branch January 19, 2022 21:28
@t1m0thyj t1m0thyj mentioned this pull request Jan 28, 2022
Merged
@zFernand0 zFernand0 self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t1m0thyj t1m0thyj t1m0thyj approved these changes

@awharn awharn awharn approved these changes

@gejohnston gejohnston Awaiting requested review from gejohnston

Assignees

@zFernand0 zFernand0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zFernand0 @t1m0thyj @awharn