Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of invalid ds member names #2104

Merged
merged 7 commits into from
Apr 1, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Mar 27, 2024

What It Does

Improves the way that invalid ds member names are handled. Before we tried to parse the invalid member names and replace control characters with �, which was prone to edge case problems. Now we stop parsing members after the first invalid member name is encountered, and add a fake member entry at the end that says "... N more members" for the ones we are unable to display.

How to Test

Run against our mainframe test system: zowe files ls am {Timothy's PMF key}.COPYBOOK.UNTERSED
This data set contains thousands of members with special characters in the name 🙂

Review Checklist

I certify that I have:

Additional Comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.05%. Comparing base (9e4a7e7) to head (7b909b5).

Files Patch % Lines
packages/zosfiles/src/methods/list/List.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2104      +/-   ##
==========================================
- Coverage   91.07%   91.05%   -0.02%     
==========================================
  Files         636      636              
  Lines       19000    19004       +4     
  Branches     3991     3883     -108     
==========================================
+ Hits        17304    17305       +1     
- Misses       1695     1698       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj requested a review from anaxceron March 27, 2024 13:02
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj requested a review from awharn March 28, 2024 13:14
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @t1m0thyj

t1m0thyj added 2 commits April 1, 2024 10:57
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

sonarqubecloud bot commented Apr 1, 2024

@t1m0thyj t1m0thyj merged commit f65d45d into master Apr 1, 2024
19 checks passed
@t1m0thyj t1m0thyj deleted the fix/invalid-member-names branch April 1, 2024 19:11
@t1m0thyj t1m0thyj added the release-minor Indicates a minor feature has been added label Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/imperative@5.23.0
  • npm: @zowe/cli-test-utils@7.24.0
  • npm: @zowe/core-for-zowe-sdk@7.24.0
  • npm: @zowe/zos-uss-for-zowe-sdk@7.24.0
  • npm: @zowe/provisioning-for-zowe-sdk@7.24.0
  • npm: @zowe/zos-console-for-zowe-sdk@7.24.0
  • npm: @zowe/zos-files-for-zowe-sdk@7.24.0
  • npm: @zowe/zos-logs-for-zowe-sdk@7.24.0
  • npm: @zowe/zosmf-for-zowe-sdk@7.24.0
  • npm: @zowe/zos-workflows-for-zowe-sdk@7.24.0
  • npm: @zowe/zos-jobs-for-zowe-sdk@7.24.0
  • npm: @zowe/zos-tso-for-zowe-sdk@7.24.0
  • npm: @zowe/cli@7.24.0

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Indicates a minor feature has been added released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants