-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor handling of invalid ds member names #2104
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
- Coverage 91.07% 91.05% -0.02%
==========================================
Files 636 636
Lines 19000 19004 +4
Branches 3991 3883 -108
==========================================
+ Hits 17304 17305 +1
- Misses 1695 1698 +3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
packages/zosfiles/__tests__/__unit__/methods/list/List.unit.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @t1m0thyj
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Quality Gate passedIssues Measures |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Improves the way that invalid ds member names are handled. Before we tried to parse the invalid member names and replace control characters with �, which was prone to edge case problems. Now we stop parsing members after the first invalid member name is encountered, and add a fake member entry at the end that says "... N more members" for the ones we are unable to display.
How to Test
Run against our mainframe test system:
zowe files ls am {Timothy's PMF key}.COPYBOOK.UNTERSED
This data set contains thousands of members with special characters in the name 🙂
Review Checklist
I certify that I have:
Additional Comments