-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incomplete files when downloading data sets #2167
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2167 +/- ##
=======================================
Coverage 91.13% 91.14%
=======================================
Files 636 637 +1
Lines 19054 19064 +10
Branches 3901 3900 -1
=======================================
+ Hits 17365 17376 +11
+ Misses 1688 1687 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix Timothy, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made one small comment -- looks good @t1m0thyj
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Quality Gate passedIssues Measures |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Fixes #744
How to Test
BufferBuilder
is fixed:zowe files copy dsclp <sourceDsname> <targetDsname> --target-zosmf-profile <profileName>
where the source dsname points to a large sequential DS (>16KB)
Review Checklist
I certify that I have:
Additional Comments
Thanks to @traeok for his
BufferBuilder
implementation in Zowe Explorer 😋