-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select members enhancement #2359
Conversation
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2359 +/- ##
========================================
Coverage 91.27% 91.27%
========================================
Files 636 638 +2
Lines 18096 18141 +45
Branches 3796 3914 +118
========================================
+ Hits 16517 16559 +42
- Misses 1578 1581 +3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Functionally, this seems to work as expected. Is it possible to change the description for
However, since we are filtering members, we don't really care about how these wildcards affect dsn qualifiers. If we can modify this description, I would change it to something like:
I'm not sure what we would use for member names for the multiple patterns example, but the command does work with multiple patterns. |
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
41d649f
to
2080f9f
Compare
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
The changes to the help text look good. I would also remove |
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and functionality LGTM, thanks Pujal for the enhancement! I noticed a typo in the typedoc and had a suggestion for one of the strings in z/OS Files SDK.
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for quickly addressing my feedback! Looks great 👍
Quality Gate passedIssues Measures |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Created a new command zowe zos-files download all-members-matching that allows the user to input patterns to download specific members of a PDS (similar to zos-files download data-sets-matching).
#2175
How to Test
Run the command zowe zos-files download all-members-matching with specific data set and patterns to download specific members.
Ex. zowe zos-files download amm "test-pds" "mem*"
Review Checklist
I certify that I have:
Additional Comments