Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first edits to ReadMe #2385

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

first edits to ReadMe #2385

wants to merge 6 commits into from

Conversation

anaxceron
Copy link
Contributor

@anaxceron anaxceron commented Dec 11, 2024

What It Does
Addresses Issue 1820

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: anaxceron <ana.ceron@broadcom.com>
@anaxceron anaxceron added documentation cli release-current Indicates that there is no new functionality being delivered labels Dec 11, 2024
@anaxceron anaxceron self-assigned this Dec 11, 2024
@anaxceron anaxceron requested a review from zFernand0 December 11, 2024 19:54
Copy link

📅 Suggested merge-by date: 12/25/2024

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (ac260f4) to head (39b8da2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2385      +/-   ##
==========================================
- Coverage   91.28%   91.27%   -0.01%     
==========================================
  Files         638      638              
  Lines       18146    18146              
  Branches     3915     3807     -108     
==========================================
- Hits        16564    16563       -1     
- Misses       1581     1582       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: anaxceron <ana.ceron@broadcom.com>
Signed-off-by: anaxceron <ana.ceron@broadcom.com>
Signed-off-by: anaxceron <ana.ceron@broadcom.com>
@anaxceron anaxceron linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Left a few comments to consider, but overall, LGTM

Zowe CLI requires NPM version 8 and Cargo version 1.72.0 (or newer) to build from source. Before proceeding, check your NPM version with `npm --version` and if it's older than 8.x, update with `npm install -g npm`. To check your version of Cargo, run `cargo --version`. Cargo can be installed using rustup: [https://rustup.rs/](https://rustup.rs/). To update Cargo, run the `rustup update` command.
## Building Zowe CLI from source

Zowe CLI requires NPM version 8 and Cargo version 1.72.0 (or newer) to build from source.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say NPM version corresponding to (or bundled with) the active LTS versions of NodeJS?

That way we don't have to update this every other year 😋


Check your NPM version with `npm --version` and if it's older than 8.x, update with `npm install -g npm`.

Check your vCargo version with `cargo --version`. Cargo can be installed using [rustup](https://rustup.rs/). To update Cargo, run the `rustup update` command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Check your vCargo version with `cargo --version`. Cargo can be installed using [rustup](https://rustup.rs/). To update Cargo, run the `rustup update` command.
Check your Cargo version with `cargo --version`. Cargo can be installed using [rustup](https://rustup.rs/). To update Cargo, run the `rustup update` command.

If you try to use Zowe CLI functionality and you get an error message that Zowe CLI failed to load any profiles, try issuing the following commands:

- `zowe config edit` to open your `~/.zowe/zowe.config.json` configuration file in your system's default text editor. Fix any properties with incorrect values.
- `zowe config secure` to have Zowe CLI prompt for your secure configuration properties in case your secure values are incorrect in your configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the need for the --global-config and --user-config depending on what the user is trying to update? 😋


- `zowe config edit` to open your `~/.zowe/zowe.config.json` configuration file in your system's default text editor. Fix any properties with incorrect values.
- `zowe config secure` to have Zowe CLI prompt for your secure configuration properties in case your secure values are incorrect in your configuration.
- `zowe config report-env` to generate a report on the status of the key areas in your working environment. Address any problems indicated in the report.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving the report-env command to the top of this bulleted list. It is (in my opinion) the one that will provide the most information that user can leverage to troubleshoot the CLI. 😋


For example usage syntax, see the readme for each API package in this repository:
For example usage syntax, see the ReadMe for each API package in this repository:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should README be all-caps? 🤔


Connection details can be managed efficiently within one file, promoting a global configuration that can be shared across teams and mainframe services. For more information on how to use profiles, visit [Zowe Docs](https://docs.zowe.org/stable/user-guide/cli-using-using-team-profiles/).
- Connection details can be managed efficiently within one file, promoting a global configuration that can be shared across teams and mainframe services. For more information on how to use profiles, see [Team configurations](https://docs.zowe.org/stable/user-guide/cli-using-using-team-profiles/) in Zowe Docs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bullet point is applicable for V3 as well, so...
Should we remove it form here? (given that it's is not a differentiator)


Secure credential encryption is included in the core CLI.
- Secure credential encryption is included in the core CLI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the bullet point above 😋

Copy link

sonarcloud bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli documentation release-current Indicates that there is no new functionality being delivered
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Still recommending v1 behavior in readme
3 participants