Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port etag to master #646

Merged
merged 13 commits into from
Feb 10, 2020
Merged

Port etag to master #646

merged 13 commits into from
Feb 10, 2020

Conversation

Alexandru-Dumitru
Copy link

Addressing issue: #596
Taking advantage of: zowe/imperative#348

  • added needed headers
  • fix current unit tests for download and upload
  • update index.ts to export new interfaces and types
  • new interfaces created
  • update download to use new imperative rest method and return etag if needed
  • update upload to use new imperative rest method
    • pass and retrieve etag if needed
  • deprecated several Upload uss functions in favor of ones that use IUploadOptions

Alexandru-Paul Dumitru added 6 commits January 21, 2020 17:01
WIP:
4987499 
- added headers
- fix current unit tests for download
- update intdex.ts to export new interfaces and types
- new interfaces created
- update download to use new imperative rest method and return etag if needed
- update upload to use new imperative rest method
    - pass and retreive etag if needed

Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
add unit tests for download + upload
b88041a 
fix small bugs in upload

Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
adding system tests
503398a 
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
fix unit tests for Upload
b4a2e37 
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Merge branch 'master' into port_etag_to_master
46d0154 
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
remove comments
2f7c187 
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
@Alexandru-Dumitru
Copy link
Author

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

58.8% 58.8% Coverage
8.3% 8.3% Duplication

will look at this tomorrow

@codecov
Copy link

codecov bot commented Jan 23, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f2a901a). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #646   +/-   ##
=========================================
  Coverage          ?   91.75%           
=========================================
  Files             ?      325           
  Lines             ?     4582           
  Branches          ?      630           
=========================================
  Hits              ?     4204           
  Misses            ?      376           
  Partials          ?        2
Impacted Files Coverage Δ
...s/zosfiles/src/cli/hMigrate/HMigrate.definition.ts 100% <ø> (ø)
.../instanceVariables/InstanceVariables.definition.ts 100% <ø> (ø)
packages/zosfiles/src/cli/upload/Upload.options.ts 100% <ø> (ø)
...li/archive/workflow/Archive.workflow.definition.ts 100% <ø> (ø)
...files/src/cli/upload/dtu/DirToUSSDir.definition.ts 100% <ø> (ø)
...es/zosfiles/src/api/constants/ZosFiles.messages.ts 100% <ø> (ø)
...s/src/cli/create/binaryPds/BinaryPDS.definition.ts 100% <ø> (ø)
packages/zosjobs/src/cli/ZosJobs.definition.ts 100% <ø> (ø)
...efinition/RetrieveWorkflowDefinition.definition.ts 100% <ø> (ø)
...zosfiles/src/cli/download/ds/Dataset.definition.ts 100% <ø> (ø)
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a901a...4be6a96. Read the comment docs.

@zFernand0
Copy link
Member

zFernand0 commented Jan 24, 2020 •
edited
Loading

Referencing a really cool comment on how someone may test this functionality.
zowe/zowe-explorer-vscode#458 (comment)

Alexandru-Paul Dumitru and others added 3 commits January 25, 2020 01:17
add more tests to increase coverage
e220c4f 
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
attempt to remove code duplication #1
eae9421 
- adding function that generates headers based on options passed and context (buffer, stream, default)

Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
@zFernand0
Merge branch 'master' into port_etag_to_master
3711417
@zFernand0 zFernand0 self-requested a review January 28, 2020 20:11
zFernand0
zFernand0 approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding job! 👍
Thanks a lot for deprecating the functions (preventing a breaking change). ✔️
Let a few comments, but no overall impact on the functionality, hence why I'm approving as it is. 😄

packages/zosfiles/__tests__/api/methods/upload/Upload.unit.test.ts Show resolved Hide resolved
packages/zosfiles/__tests__/api/methods/upload/Upload.unit.test.ts Outdated Show resolved Hide resolved
packages/zosfiles/src/api/doc/IOptionsFullResponse.ts Show resolved Hide resolved
packages/zosfiles/src/api/doc/IRestClientResponse.ts Show resolved Hide resolved
packages/zosfiles/src/api/doc/types/ZosmfRestClientProperties.ts Show resolved Hide resolved
packages/zosfiles/src/api/methods/upload/Upload.ts Show resolved Hide resolved
packages/zosfiles/src/api/methods/upload/Upload.ts Show resolved Hide resolved
@zFernand0
remove trailing commas
7fb7199 
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@zFernand0 zFernand0 force-pushed the port_etag_to_master branch from 680aa0b to 7fb7199 Compare February 7, 2020 16:11
refactor test
4be6a96 
- split optional params into unit tests
- create group of tests for deprecated function

Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

99.3% 99.3% Coverage
0.1% 0.1% Duplication

@zFernand0 zFernand0 merged commit debd676 into master Feb 10, 2020
@zFernand0 zFernand0 deleted the port_etag_to_master branch February 10, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zFernand0 zFernand0 zFernand0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexandru-Dumitru @zFernand0