Implementation of new "like" parameter for data set creation

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to the Zowe CLI package will be documented in this file.
 
+## Recent Changes
+
+- Add "like" parameter to `ICreateDataSetOptions` type (implementation of new zOSMF "like" REST parameter in API)
+
 ## `6.18.0`
 
 - Add the --fail-fast option to the `zowe zos-files download all-members` command

packages/zosfiles/__tests__/__system__/api/methods/create/Create.system.test.ts

@@ -106,6 +106,73 @@ describe("Create data set", () => {
     }, LONGER_TIMEOUT);
 });
 
+describe("Allocate Like", () => {
+    let dsnameLike: string;
+    const options: ICreateDataSetOptions = {
+        dsorg: "PO",
+        alcunit: "CYL",
+        primary: 20,
+        recfm: "FB",
+        blksize: 6160,
+        lrecl: 80,
+        showAttributes: true
+    } as any;
+
+    beforeAll(async () => {
+        testEnvironment = await TestEnvironment.setUp({
+            testName: "zos_create_dataset_like"
+        });
+        defaultSystem = testEnvironment.systemTestProperties;
+
+        REAL_SESSION = TestEnvironment.createZosmfSession(testEnvironment);
+        dsnameLike = `${dsname}.LIKE`;
+    });
+
+    afterAll(async () => {
+        await TestEnvironment.cleanUp(testEnvironment);
+    });
+
+    beforeEach(async () => {
+        try {
+            await Create.dataSet(REAL_SESSION, CreateDataSetTypeEnum.DATA_SET_CLASSIC, dsname, options);
+        } catch (error) {
+            Imperative.console.info("Error: " + inspect(error));
+        }
+    });
+
+    afterEach(async () => {
+        try {
+            await Delete.dataSet(REAL_SESSION, dsname);
+            await Delete.dataSet(REAL_SESSION, dsnameLike);
+        } catch (error) {
+            Imperative.console.info("Error: " + inspect(error));
+        }
+    });
+
+    it("should be able to allocate like from a sequential data set", async () => {
+        const options2: ICreateDataSetOptions = {
+            like: dsname,
+            showAttributes: true
+        } as any;
+        let error;
+        let response;
+
+        try {
+            response = await Create.dataSet(REAL_SESSION, CreateDataSetTypeEnum.DATA_SET_LIKE, dsnameLike, options2);
+            Imperative.console.info("Response: " + inspect(response));
+        } catch (err) {
+            error = err;
+            Imperative.console.info("Error: " + inspect(error));
+        }
+
+        expect(error).toBeFalsy();
+        expect(response).toBeTruthy();
+
+        expect(response.success).toBe(true);
+        expect(response.commandResponse).toContain(ZosFilesMessages.dataSetCreatedSuccessfully.message);
+    });
+})
+
 describe("Create VSAM", () => {
 
     beforeAll(async () => {

packages/zosfiles/__tests__/api/methods/create/Create.unit.test.ts

@@ -13,6 +13,7 @@ import { ImperativeError, TextUtils } from "@zowe/imperative";
 import { Create, CreateDataSetTypeEnum, ZosFilesConstants, CreateDefaults, Invoke, ICreateVsamOptions } from "../../../../";
 import { ZosmfRestClient } from "../../../../../rest/";
 import { ZosFilesMessages } from "../../../../src/api/constants/ZosFiles.messages";
+import { Get, List } from "../../../../src/api";
 
 describe("Create data set", () => {
     const dummySession: any = {};
@@ -139,6 +140,14 @@ describe("Create data set", () => {
             );
         });
 
+        it("should be able to allocate like from a sequential data set", async () => {
+            const custOptions2 = { like: dataSetName, showAttributes: true };
+
+            const response = await Create.dataSet(dummySession, CreateDataSetTypeEnum.DATA_SET_SEQUENTIAL, "testing2", custOptions2);
+
+            expect(response.commandResponse).toContain("created successfully");
+        });
+
         it("should be able to create a sequential data set using the primary allocation and secondary allocation options", async () => {
             const custOptions = {
                 dsorg: "PS",

packages/zosfiles/src/api/methods/create/Create.ts

@@ -54,6 +54,9 @@ export class Create {
         // Required
         ImperativeExpect.toNotBeNullOrUndefined(dataSetName, ZosFilesMessages.missingDatasetName.message);
 
+        // Remove type if "like" attribute is set...attributes will be determined from other data set
+        if (!isNullOrUndefined(tempOptions.like)) { cmdType = CreateDataSetTypeEnum.DATA_SET_LIKE }
+
         switch (cmdType) {
             case CreateDataSetTypeEnum.DATA_SET_PARTITIONED:
                 tempOptions = {...CreateDefaults.DATA_SET.PARTITIONED, ...tempOptions};
@@ -70,6 +73,9 @@ export class Create {
             case CreateDataSetTypeEnum.DATA_SET_CLASSIC:
                 tempOptions = {...CreateDefaults.DATA_SET.CLASSIC, ...tempOptions};
                 break;
+            case CreateDataSetTypeEnum.DATA_SET_LIKE:
+                // "like" attribute is set, so attributes should not be added
+                break;
             default:
                 validCmdType = false;
                 break;
@@ -96,7 +102,7 @@ export class Create {
                         }
                     }
                 } else {
-                    if (isNullOrUndefined(tempOptions.secondary)) {
+                    if (isNullOrUndefined(tempOptions.secondary) && cmdType !== CreateDataSetTypeEnum.DATA_SET_LIKE) {
                         if (cmdType !== CreateDataSetTypeEnum.DATA_SET_BINARY) {
                             tempOptions.secondary = 1;
                         } else {
@@ -271,6 +277,10 @@ export class Create {
                     case "volser":
                         // no validation
 
+                        break;
+                    case "like":
+                        // no validation
+
                         break;
 
                     default:

packages/zosfiles/src/api/methods/create/CreateDataSetType.enum.ts

@@ -17,5 +17,6 @@ export const enum CreateDataSetTypeEnum {
     DATA_SET_C,
     DATA_SET_CLASSIC,
     DATA_SET_PARTITIONED,
-    DATA_SET_SEQUENTIAL
+    DATA_SET_SEQUENTIAL,
+    DATA_SET_LIKE
 }

packages/zosfiles/src/api/methods/create/doc/ICreateDataSetOptions.ts

@@ -123,4 +123,9 @@ export interface ICreateDataSetOptions {
      * @type {string}
      */
     size?: string;
+    /**
+     * The name of another data set from which to copy attributes
+     * @type {string}
+     */
+    like?: string;
 }