Turned SDK APIs into context manager #283
Conversation
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
There was a problem hiding this comment.
Thanks @aadityasinha-dotcom, left a comment 🙂
Could you please also update the examples in SDK readmes to use with statement? For example, in the z/OS Console readme:
from zowe.core_for_zowe_sdk import ProfileManager
from zowe.zos_console_for_zowe_sdk import Console
profile = ProfileManager().load(profile_name="zosmf")
with Console(profile) as console_info:
print(console_info.issue_command(command="D IPLINFO", console="EMCS"))
Co-authored-by: Timothy Johnson <timothy.johnson@broadcom.com> Signed-off-by: Aaditya Sinha <75474786+aadityasinha-dotcom@users.noreply.github.com>
| def __enter__(self): | ||
| return self | ||
|
|
||
| def __exit__(self, exc_type, exception, traceback): |
There was a problem hiding this comment.
Will there be any use of exc_type, exception, traceback?
I am curious 🤔
There was a problem hiding this comment.
I think these parameters could be used to do exception handling inside the __exit__ function 😋
https://realpython.com/python-with-statement/#handling-exceptions-in-a-context-manager
In our case we always want to clean up the request handler and session object, regardless of whether an error has been raised, so I don't think we need to use them at all.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
- Coverage 89.32% 89.27% -0.05%
==========================================
Files 53 53
Lines 2529 2536 +7
==========================================
+ Hits 2259 2264 +5
- Misses 270 272 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
What It Does
Resolves #145
How to Test
Review Checklist
I certify that I have:
Additional Comments