add checking for favorites before deleting job

Signed-off-by: Richelle Anne Craw <richelleanne.craw@broadcom.com>
zowe · Mar 3, 2021 · 133818f · 133818f
1 parent bc944b8
commit 133818f
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/packages/zowe-explorer/src/job/ZosJobsProvider.ts b/packages/zowe-explorer/src/job/ZosJobsProvider.ts
@@ -455,17 +455,19 @@ export class ZosJobsProvider extends ZoweTreeProvider implements IZoweTree<IZowe
         // Get node's profile node in favorites
         const profileName = node.getProfileName();
         const profileNodeInFavorites = this.findMatchingProfileInArray(this.mFavorites, profileName);
-        const startLength = profileNodeInFavorites.children.length;
-        profileNodeInFavorites.children = profileNodeInFavorites.children.filter(
-            (temp) => !(temp.label === node.label && temp.contextValue.startsWith(node.contextValue))
-        );
-        // Remove profile node from Favorites if it contains no more favorites.
-        if (profileNodeInFavorites.children.length < 1) {
-            return this.removeFavProfile(profileName, false);
-        }
-        if (startLength !== profileNodeInFavorites.children.length) {
-            await this.updateFavorites();
-            this.refreshElement(this.mFavoriteSession);
+        if (profileNodeInFavorites) {
+            const startLength = profileNodeInFavorites.children.length;
+            profileNodeInFavorites.children = profileNodeInFavorites.children.filter(
+                (temp) => !(temp.label === node.label && temp.contextValue.startsWith(node.contextValue))
+            );
+            // Remove profile node from Favorites if it contains no more favorites.
+            if (profileNodeInFavorites.children.length < 1) {
+                return this.removeFavProfile(profileName, false);
+            }
+            if (startLength !== profileNodeInFavorites.children.length) {
+                await this.updateFavorites();
+                this.refreshElement(this.mFavoriteSession);
+            }
         }
         return;
     }