Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USS Tree collapses after folder rename #650

Closed
lauren-li opened this issue Mar 31, 2020 · 4 comments
Closed

USS Tree collapses after folder rename #650

lauren-li opened this issue Mar 31, 2020 · 4 comments
Assignees
Labels

Comments

@lauren-li
Copy link
Contributor

lauren-li commented Mar 31, 2020

When renaming a USS folder, the entire tree will collapse (to refresh the contents) after the rename. This means the user has to subsequently go look for the renamed folder in order to continue working with it. It would be a friendlier UX if the tree was able to stay open after the rename. (Perhaps we could achieve this by refreshing at the folder level, rather than refreshing the whole USS tree.)

ussRename2

In addition:

USSTree collapses when a new directory or file is created. It is inconsistent with the way Dataset works. The list should just refresh and not collapse

  • Note: This just seems to happen at the top level, and not with creation under subfolders.
@zFernand0
Copy link
Member

zFernand0 commented May 27, 2020

Crazy idea:

  • Recursively goo back (or node->parent - double-linked-list?) until the root doing refreshElements (which should keep the parent elements open) 😋

@zdmullen
Copy link
Contributor

zdmullen commented Jun 25, 2020

Revisit after the pull request for issue #563 is merged. (#817)

@zdmullen zdmullen modified the milestones: Developer, 1.8 Release Jun 25, 2020
@JillieBeanSim JillieBeanSim self-assigned this Jun 30, 2020
@katelynienaber
Copy link
Contributor

katelynienaber commented Jul 29, 2020

Some research:

  • Creating file/folder from context menu does not cause the error
  • Creating file/folder at the session level does cause the error
    (this should no longer be an issue after this PR is merged, because the Create button will have been removed from the toolbar)
  • Renaming a file does cause the error

@JillieBeanSim
Copy link
Contributor

Thanks @katelynienaber we can revisit this after the PR is merged in

@crawr crawr modified the milestones: 1.8 Release, 1.9 Release Jul 31, 2020
@zFernand0 zFernand0 removed this from the 1.9 Release milestone Nov 19, 2020
@lauren-li lauren-li self-assigned this Jan 18, 2021
@crawr crawr added Sprint 3 and removed Sprint 1 labels Mar 2, 2021
@jellypuno jellypuno added this to the 1.13 Release milestone Mar 2, 2021
@crawr crawr removed this from the 1.13 Release milestone Mar 11, 2021
jellypuno added a commit that referenced this issue Apr 21, 2021
Issue #650 partial fix: USS tree collapses after folder rename
@crawr crawr closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants