Feature/multi select/context menu/data sets

[KutluOzel-b]

Proposed changes

Added multiple selection to manage context menu of Datasets and Jobs views

Datasets

• Removed Allocate Alike
• Removed Create New Member
• Removed Rename
• Add / Remove Favourites
• Add Delete
• Add Migrate Datasets
• Add Pull From Mainframe
• Add Recall Datasets
• Add Refresh
• Add Show Datasets attributes
• Add Upload Member
• Add Edit

Jobs

• Removed Issue Modify Command
• Add / Remove Favourites
• Add delete
• Add Download Files
• Add Get JCL (multiple jcl in a single file )
• Add Issue Multiple Stops

Release Notes

Milestone:

#1428

Completed DS and Jobs Views parts

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• [ x] Bugfix (non-breaking change which fixes an issue)
• [ x] New feature (non-breaking change which adds functionality)
• [ x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• [x ] I have read the CONTRIBUTOR GUIDANCE wiki
• [ x] PR title follows Conventional Commits Guidelines
• [ x] PR Description is included
• gif or screenshot is included if visual changes are made
• [ x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• [x ] All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• [x ] There is coverage for the code that I have added
• [ x] I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

[zFernand0]

There are a few unexpected things with the add to favorites compared to what the main branch does 😢

PR: uses the selected node
Main: uses the node clicked

Similar behavior happens on other trees
Here is a GIF to help explain what's happening (only includes the Jobs tree)
my intention was to do it for all trees, but the gif got a bit too long

[KutluOzel-b]

Thanks @zFernand0 for reviewing it and good catch 👍 . That made me realize that we have the same issue on other views as well and leads some other bugs like selection of unintended files . So I changed the getting of selected nodes method and fixed it at bc294be

The modifications also includes #1882 this pr context.

It seems it is fixed now but being skeptical for both jobs / uss / ds views would be beneficial while testing.

[JillieBeanSim]

DATA SETS

• multi-select upload member didn't upload into both datasets only the latest selected
• ds member pull from mainframe flips through files in editor for each selected with only a single tab showing at all times when file not already opened. seems like strange behavior. maybe have it behave like edit does, that one works really well.
• migrate & recall still require the tree view to be refreshed to see changes causing the sessions to close, not relevant to this PR, I believe it's prior behavior but noting here to remember to create issue for this

JOBS

• same issue here as in DS view with pull from mainframe multi select
• get JCL only opened the first selected of multiple in text editor

[KutluOzel-b]

@JillieBeanSim Thanks for the review and comments 👍

DATA SETS

multi-select upload member didn't upload into both datasets only the latest selected

Uploading multiple files(members) to a single dataset is what is available now. Still it shouldn't show up on the context menu though when multi selection happens.I thought It was unnecessary to add such behaviour. What do you think ? Is there a use case for it or would be nice to add ?

ds member pull from mainframe flips through files in editor for each selected with only a single tab showing at all times when file not already opened. seems like strange behavior. maybe have it behave like edit does, that one works really well.

Resolved in commit : a44b738

JOBS

same issue here as in DS view with pull from mainframe multi select

Resolved in commit : a44b738

get JCL only opened the first selected of multiple in text editor

This is actually related with the approach . I'm adding JCL statements together into a single file. I thought it would be more elegant way to manage multiple JCL Statements. What do you think ?
here what is it looks like ;

[JillieBeanSim]

Hey @KutluOzel-b thanks for addressing my comments.

For the getJCL, I don't think it is a good idea to concatenate in to a single file. We may in the future bring in a functionality to edit and re-submit and this could prove problematic.

For the DS upload, I don't know of a use case for uploading the same file into different DS's. If the option can be removed from the right-click menu that would be good to avoid bugs/issues being raised if users try and it doesn't work.

If we are not sure how to accomplish these atm, we can always just remove these items from the multi select right-click menu for the time being and keep those issues open with comments to be addressed in a future PR.

[zFernand0]

based on our quick discussion on standup, it seems like we still need to remove the getJCL and upload DS on multi-selection 😋
Once those are removed, I'm happy to approve.

changes applied

[zFernand0]

LGTM! 😋
Thanks for addressing the feedback so quickly 👍

[JillieBeanSim]

LGTM! thanks @KutluOzel-b for the fixes and updates

[zFernand0]

LGTM 😋