Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(changelog): Introduce changelog workflow and update templates #1968

Merged
merged 9 commits into from
Oct 18, 2022

Conversation

zFernand0
Copy link
Member

@zFernand0 zFernand0 commented Oct 12, 2022

Proposed changes

These changes were tested in:

Release Notes

Milestone: N/A

Changelog: N/A

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 74.71% // Head: 74.71% // No change to project coverage 👍

Coverage data is based on head (1cfd4f1) compared to base (891080b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1968   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files          63       63           
  Lines        7070     7070           
  Branches     1523     1523           
=======================================
  Hits         5282     5282           
  Misses       1781     1781           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zFernand0 zFernand0 marked this pull request as ready for review October 12, 2022 17:14
JillieBeanSim
JillieBeanSim previously approved these changes Oct 13, 2022
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks @zFernand0

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
JillieBeanSim
JillieBeanSim previously approved these changes Oct 13, 2022
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim
Copy link
Contributor

Created the label no-changelog for PRs not requiring the update and added a note to the issue for adding info about the label in the contributing doc.

@JTonda JTonda requested a review from rudyflores October 13, 2022 15:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zFernand0 zFernand0 merged commit 5ae4256 into main Oct 18, 2022
@zFernand0 zFernand0 deleted the fix/970 branch October 18, 2022 15:30
@zFernand0 zFernand0 added the no-changelog Add to PR's that don't require a CHANGELOG update label Oct 18, 2022
@zFernand0 zFernand0 self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
None yet
3 participants