Make Zowe Explorer independent of Zowe CLI installation #1993

JillieBeanSim · 2022-10-27T21:43:41Z

Signed-off-by: Billie Simmons 49491949+JillieBeanSim@users.noreply.github.com

Proposed changes

This PR will

check for and create if needed the .zowe/settings/imperative.json file making Zowe Explorer independent of the Zowe CLI installation.
fixes the watcher of the Secure Credentials Enabled setting, to update file when checked or unchecked.
will read and parse the file if existing and changing the CredentialManager value then write back. This is done just incase imperative, zowe cli, or an extender/plugin decide to introduce more values to this file.

Release Notes

Milestone: 2.4.1

Changelog:

Added independence from Zowe CLI installation by creating the ~/.zowe/settings/imperative.json file during activation if it doesn't already exist. This file is for Zowe Explorer to know the Security Credential Manager used for secure profile information.
Fixed the Secure Credentials Enabled setting to update the ~/.zowe/settings/imperative.json file upon change of the setting without overwriting other data in the file.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

Screen.Recording.2022-10-28.at.3.38.01.PM.mov

Screen.Recording.2022-10-28.at.4.21.10.PM.mov

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

codecov · 2022-10-28T01:28:28Z

Codecov Report

Base: 74.29% // Head: 74.44% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (09ed1a9) compared to base (5fa7001).
Patch coverage: 85.10% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1993      +/-   ##
==========================================
+ Coverage   74.29%   74.44%   +0.14%     
==========================================
  Files          63       63              
  Lines        7108     7129      +21     
  Branches     1538     1543       +5     
==========================================
+ Hits         5281     5307      +26     
+ Misses       1820     1815       -5     
  Partials        7        7

Impacted Files	Coverage Δ
packages/zowe-explorer/src/extension.ts	`38.38% <40.00%> (-0.53%)`	⬇️
packages/zowe-explorer/src/globals.ts	`93.00% <50.00%> (-3.74%)`	⬇️
packages/zowe-explorer/src/Profiles.ts	`36.09% <100.00%> (+0.22%)`	⬆️
packages/zowe-explorer/src/utils/ProfilesUtils.ts	`68.06% <100.00%> (+5.48%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim · 2022-10-31T16:25:43Z

The code smell is about the comment with TODO in it, which I think can stay until the issue mentioned is solved and we consume and use the changes.

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

zFernand0

LGTM! 😋

zFernand0 · 2022-11-08T18:51:00Z

packages/zowe-explorer/__tests__/__unit__/extension.unit.test.ts

        // tslint:disable-next-line: no-magic-numbers
-        expect(globalMocks.mockMkdirSync.mock.calls.length).toBe(4);
+        expect(globalMocks.mockMkdirSync.mock.calls.length).toBe(6);


we should probably remove tslint in favor of eslint.
and for these kind of tests, we could have the eslint configuration for tests exclude the magic-number rules 😋
Example: https://github.com/zowe/zowe-cli/blob/master/.eslintrc.js#L14-L36

it doesn't look like Zowe Explorer has changed over to eslint, only ZE API & FTP

🤦 you are right
the first step is to migrate to eslint 😋

packages/zowe-explorer/CHANGELOG.md

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

sonarqubecloud · 2022-11-08T20:47:17Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

create a function to handle all .zowe file/dir creation

391d9e0

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim added this to the 2.5.0 milestone Oct 27, 2022

JillieBeanSim linked an issue Oct 27, 2022 that may be closed by this pull request

ZE: create all .zowe subfolders needed (e.g. ~/.zowe/settings) #1850

Closed

JillieBeanSim added 3 commits October 27, 2022 21:00

fix the watcher for the security value change

d8ab296

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

working on unit test fixes

84f9bf7

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

fix broken unit tests

b52ffb0

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim added 7 commits October 27, 2022 21:33

update to initialization of files

5752471

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

fix lint issue

8d1adcd

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

fix code smells

179fa1a

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

prettify json written to file

f7a32b2

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

read file and update if file already exists

f8dd437

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

remove console.log

5cd4656

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

update flow

b17e120

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim requested review from zFernand0 and rudyflores October 28, 2022 21:17

JillieBeanSim self-assigned this Oct 28, 2022

JillieBeanSim added 5 commits October 28, 2022 19:37

add unit tests

8b87143

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

unit tests

b10e77c

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

add CHANGELOG

cb6a3ca

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

add issue link to CHANGELOG item

80167e9

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

fix code smells

e2c7ada

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim marked this pull request as ready for review October 28, 2022 23:55

JillieBeanSim marked this pull request as draft October 29, 2022 00:04

fix path for windows unit tests

fbc105e

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim marked this pull request as ready for review October 31, 2022 15:02

anaxceron mentioned this pull request Nov 3, 2022

Documentation for updated ZE install zowe/docs-site#2476

Closed

remove un-needed line

a3f6fc0

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JTonda requested a review from t1m0thyj November 8, 2022 16:07

JillieBeanSim modified the milestones: 2.5.0, 2.4.1 Nov 8, 2022

zFernand0 previously approved these changes Nov 8, 2022

View reviewed changes

zFernand0 reviewed Nov 8, 2022

View reviewed changes

packages/zowe-explorer/CHANGELOG.md Outdated Show resolved Hide resolved

JillieBeanSim mentioned this pull request Nov 8, 2022

Question - Is the installation of Zowe CLI on the workstation still a prerequisite for using Zowe Explorer? #1898

Closed

JillieBeanSim added 2 commits November 8, 2022 15:37

Merge branch 'main' into create-settings-file

f879075

update CHANGELOG

4df67a8

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim dismissed zFernand0’s stale review via 4df67a8 November 8, 2022 20:44

remove unneeded subtitle

09ed1a9

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim requested a review from zFernand0 November 8, 2022 20:45

t1m0thyj approved these changes Nov 10, 2022

View reviewed changes

zFernand0 approved these changes Nov 10, 2022

View reviewed changes

JillieBeanSim merged commit 720e8e0 into main Nov 10, 2022

JillieBeanSim deleted the create-settings-file branch November 10, 2022 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Zowe Explorer independent of Zowe CLI installation #1993

Make Zowe Explorer independent of Zowe CLI installation #1993

JillieBeanSim commented Oct 27, 2022 •

edited

Loading

codecov bot commented Oct 28, 2022 •

edited

Loading

JillieBeanSim commented Oct 31, 2022

zFernand0 left a comment

zFernand0 Nov 8, 2022

JillieBeanSim Nov 8, 2022

zFernand0 Nov 9, 2022

sonarqubecloud bot commented Nov 8, 2022

Make Zowe Explorer independent of Zowe CLI installation #1993

Make Zowe Explorer independent of Zowe CLI installation #1993

Conversation

JillieBeanSim commented Oct 27, 2022 • edited Loading

Proposed changes

Release Notes

Types of changes

Checklist

Further comments

codecov bot commented Oct 28, 2022 • edited Loading

Codecov Report

JillieBeanSim commented Oct 31, 2022

zFernand0 left a comment

Choose a reason for hiding this comment

zFernand0 Nov 8, 2022

Choose a reason for hiding this comment

JillieBeanSim Nov 8, 2022

Choose a reason for hiding this comment

zFernand0 Nov 9, 2022

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 8, 2022

JillieBeanSim commented Oct 27, 2022 •

edited

Loading

codecov bot commented Oct 28, 2022 •

edited

Loading